| Message ID | 20200831134836.20189-6-m.felsch@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] net: phy: smsc: skip ENERGYON interrupt if disabled | expand |
On Mon, Aug 31, 2020 at 03:48:36PM +0200, Marco Felsch wrote: > Don't reset the phy without respect to the phy-state-machine because > this breaks the phy IRQ mode. We can archive the same behaviour if the > refclk in is specified. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > drivers/net/phy/smsc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > index b98a7845681f..67adf11ef958 100644 > --- a/drivers/net/phy/smsc.c > +++ b/drivers/net/phy/smsc.c > @@ -337,7 +337,6 @@ static struct phy_driver smsc_phy_driver[] = { > .name = "SMSC LAN8710/LAN8720", > > /* PHY_BASIC_FEATURES */ > - .flags = PHY_RST_AFTER_CLK_EN, > > .probe = smsc_phy_probe, Hi Marco There are two PHYs using PHY_RST_AFTER_CLK_EN. What about the other one? Andrew
Hi Andrew, On 20-08-31 16:11, Andrew Lunn wrote: > On Mon, Aug 31, 2020 at 03:48:36PM +0200, Marco Felsch wrote: > > Don't reset the phy without respect to the phy-state-machine because > > this breaks the phy IRQ mode. We can archive the same behaviour if the > > refclk in is specified. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > drivers/net/phy/smsc.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > > index b98a7845681f..67adf11ef958 100644 > > --- a/drivers/net/phy/smsc.c > > +++ b/drivers/net/phy/smsc.c > > @@ -337,7 +337,6 @@ static struct phy_driver smsc_phy_driver[] = { > > .name = "SMSC LAN8710/LAN8720", > > > > /* PHY_BASIC_FEATURES */ > > - .flags = PHY_RST_AFTER_CLK_EN, > > > > .probe = smsc_phy_probe, > > Hi Marco > > There are two PHYs using PHY_RST_AFTER_CLK_EN. What about the other > one? I think that they are broken too but I can't verify this therefore I left them out. Regards, Marco > > Andrew >
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index b98a7845681f..67adf11ef958 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -337,7 +337,6 @@ static struct phy_driver smsc_phy_driver[] = { .name = "SMSC LAN8710/LAN8720", /* PHY_BASIC_FEATURES */ - .flags = PHY_RST_AFTER_CLK_EN, .probe = smsc_phy_probe,
Don't reset the phy without respect to the phy-state-machine because this breaks the phy IRQ mode. We can archive the same behaviour if the refclk in is specified. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/net/phy/smsc.c | 1 - 1 file changed, 1 deletion(-)