@@ -342,9 +342,9 @@ static int chip_fault_show(struct devlink_fmsg *fmsg,
level = event->event.chip.err_level;
if (level < FAULT_LEVEL_MAX)
- strncpy(level_str, fault_level[level], strlen(fault_level[level]));
+ strncpy(level_str, fault_level[level], strlen(fault_level[level]) + 1);
else
- strncpy(level_str, "Unknown", strlen("Unknown"));
+ strncpy(level_str, "Unknown", sizeof(level_str));
if (level == FAULT_LEVEL_SERIOUS_FLR) {
err = devlink_fmsg_u32_pair_put(fmsg, "Function level err func_id",
@@ -388,9 +388,9 @@ static int fault_report_show(struct devlink_fmsg *fmsg,
int err;
if (event->type < FAULT_TYPE_MAX)
- strncpy(type_str, fault_type[event->type], strlen(fault_type[event->type]));
+ strncpy(type_str, fault_type[event->type], strlen(fault_type[event->type]) + 1);
else
- strncpy(type_str, "Unknown", strlen("Unknown"));
+ strncpy(type_str, "Unknown", sizeof(type_str));
err = devlink_fmsg_string_pair_put(fmsg, "Fault type", type_str);
if (err)
fix the compile warnings of 'strncpy' output truncated before terminating nul copying N bytes from a string of the same length Signed-off-by: Luo bin <luobin9@huawei.com> Reported-by: kernel test robot <lkp@intel.com> --- drivers/net/ethernet/huawei/hinic/hinic_devlink.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)