From patchwork Mon Mar 17 13:52:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 26356 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f72.google.com (mail-qa0-f72.google.com [209.85.216.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 85F33202FA for ; Mon, 17 Mar 2014 13:53:25 +0000 (UTC) Received: by mail-qa0-f72.google.com with SMTP id f11sf12169814qae.7 for ; Mon, 17 Mar 2014 06:53:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=7Oe7uXCGAiyQ+Z9AKYUvb0ss98iBaHan3PF2YQRlP8A=; b=Z9p0bRby1icF154lU+iJqJuCWV8btZ0RgegaBogf8TcC+R9/T8LxY/lB+sfe2RtBcy ZdQXeeqCCZaDB6v/zGe+IC6cNmcoIDQqENbXEBKmLRw46c8bbshFYek24q73PSD8RXXx q+XcKsk+MtPMeuYOgrOCKvGddC0Mdl8b4jtfMmug1th0UR859Mp+k34CiLkY25dzRBPE n7N9nLlsn0mg03fYKFJc/QNQbL0of0G3XxikEjjTjh5pkBoWYqY1maSUri7cA2JGDc3j zRioJNuZN7DZvNJ4DA90oR+u5rijfz90SIsdsLRd1f4sDq1I7ojwfsABU/iqQbIRqK1d UDEw== X-Gm-Message-State: ALoCoQkS5bVvK9dLYXTTmpTXGSZW2swLobrsz/ekQkBTDvS5NixP0kCjojt4S38Ko6E1o9cTsvqd X-Received: by 10.236.2.38 with SMTP id 26mr2444749yhe.8.1395064405328; Mon, 17 Mar 2014 06:53:25 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.98.97 with SMTP id n88ls1665392qge.64.gmail; Mon, 17 Mar 2014 06:53:25 -0700 (PDT) X-Received: by 10.58.91.101 with SMTP id cd5mr19712108veb.5.1395064405054; Mon, 17 Mar 2014 06:53:25 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id x7si2817397vel.108.2014.03.17.06.53.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Mar 2014 06:53:25 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id lh14so5660406vcb.6 for ; Mon, 17 Mar 2014 06:53:25 -0700 (PDT) X-Received: by 10.58.229.4 with SMTP id sm4mr20560728vec.10.1395064404976; Mon, 17 Mar 2014 06:53:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp129126vck; Mon, 17 Mar 2014 06:53:24 -0700 (PDT) X-Received: by 10.52.247.231 with SMTP id yh7mr668626vdc.34.1395064404492; Mon, 17 Mar 2014 06:53:24 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id i7si2818480vei.85.2014.03.17.06.53.23 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 17 Mar 2014 06:53:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WPXy2-00013H-1p; Mon, 17 Mar 2014 13:52:38 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WPXy0-00012A-AW for xen-devel@lists.xen.org; Mon, 17 Mar 2014 13:52:36 +0000 Received: from [85.158.143.35:3381] by server-3.bemta-4.messagelabs.com id 05/60-13602-32EF6235; Mon, 17 Mar 2014 13:52:35 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-13.tower-21.messagelabs.com!1395064353!2634464!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1912 invoked from network); 17 Mar 2014 13:52:35 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-13.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 17 Mar 2014 13:52:35 -0000 X-IronPort-AV: E=Sophos;i="4.97,670,1389744000"; d="scan'208";a="112110138" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP; 17 Mar 2014 13:52:32 +0000 Received: from norwich.cam.xci-test.com (10.80.248.129) by smtprelay.citrix.com (10.13.107.79) with Microsoft SMTP Server id 14.2.342.4; Mon, 17 Mar 2014 09:52:32 -0400 Received: from drall.uk.xensource.com ([10.80.16.71] helo=drall.uk.xensource.com.) by norwich.cam.xci-test.com with esmtp (Exim 4.72) (envelope-from ) id 1WPXxw-0000jH-9G; Mon, 17 Mar 2014 13:52:32 +0000 From: Ian Campbell To: Date: Mon, 17 Mar 2014 13:52:31 +0000 Message-ID: <1395064352-2128-3-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395064315.18221.26.camel@kazak.uk.xensource.com> References: <1395064315.18221.26.camel@kazak.uk.xensource.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: julien.grall@linaro.org, tim@xen.org, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Xen-devel] [PATCH 3/4] xen: arm: add barrier before sev in smp_spin_table_cpu_up X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: This ensures that the writeq to the release address has occurred. In reality there is a dsb() in the iounmap() (in the eventual write_pte()) but make it explicit. The ARMv8 ARM recommends that sev() is usually accompanied by a dsb(), the only other uses are in the v7 spinlock code which includes a dsb() already. Signed-off-by: Ian Campbell --- v2: typos in the commit message --- xen/arch/arm/arm64/smpboot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 9146476..8e2ecf2 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -36,6 +36,7 @@ static int __init smp_spin_table_cpu_up(int cpu) iounmap(release); + dsb(); /* Ensure that the write to cpu_release_addr has occurred. */ sev(); return cpu_up_send_sgi(cpu);