| Message ID | 20201008235934.8931-5-wcheng@codeaurora.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce PMIC based USB type C detection | expand |
On Thu, Oct 08, 2020 at 04:59:34PM -0700, Wesley Cheng wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM8150B. This will provide the VBUS source to connected > peripherals. > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++ > arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > index 2bf385f5a55a..49ea597cc0c5 100644 > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > @@ -53,6 +53,12 @@ power-on@800 { > status = "disabled"; > }; > > + pm8150b_vbus: regulator@1100 { > + compatible = "qcom,pm8150b-vbus-reg"; > + status = "disabled"; > + reg = <0x1100>; > + }; > + > pm8150b_typec: usb-typec@1500 { > compatible = "qcom,pm8150b-usb-typec"; > status = "disabled"; > diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > index 6c6325c3af59..ba3b5b802954 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > @@ -409,6 +409,10 @@ &ufs_mem_phy { > vdda-pll-max-microamp = <19000>; > }; > > +&pm8150b_vbus { > + status = "okay"; > +}; Why aren't you enabling the TypeC node and providing a complete example? > + > &usb_1_hsphy { > status = "okay"; > vdda-pll-supply = <&vdd_usb_hs_core>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
On 10/13/2020 8:03 AM, Rob Herring wrote: > On Thu, Oct 08, 2020 at 04:59:34PM -0700, Wesley Cheng wrote: >> Add the required DTS node for the USB VBUS output regulator, which is >> available on PM8150B. This will provide the VBUS source to connected >> peripherals. >> >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++ >> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi >> index 2bf385f5a55a..49ea597cc0c5 100644 >> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi >> @@ -53,6 +53,12 @@ power-on@800 { >> status = "disabled"; >> }; >> >> + pm8150b_vbus: regulator@1100 { >> + compatible = "qcom,pm8150b-vbus-reg"; >> + status = "disabled"; >> + reg = <0x1100>; >> + }; >> + >> pm8150b_typec: usb-typec@1500 { >> compatible = "qcom,pm8150b-usb-typec"; >> status = "disabled"; >> diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts >> index 6c6325c3af59..ba3b5b802954 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts >> @@ -409,6 +409,10 @@ &ufs_mem_phy { >> vdda-pll-max-microamp = <19000>; >> }; >> >> +&pm8150b_vbus { >> + status = "okay"; >> +}; > > Why aren't you enabling the TypeC node and providing a complete example? > Hi Rob, I have another patch series which enables the type C node and adds QMP PHY driver changes for setting the SS lane select MUX. https://patchwork.kernel.org/project/linux-arm-msm/list/?series=361971 Just wanted to work on getting a PMIC based type C driver out there, which can be utilized in designs where the QMP PHY lane select mux is not going to be used. (ie using a FUSB340 as a lane select mux instead of the QMP PHY mux) Thanks Regards, Wesley Cheng
diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi index 2bf385f5a55a..49ea597cc0c5 100644 --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi @@ -53,6 +53,12 @@ power-on@800 { status = "disabled"; }; + pm8150b_vbus: regulator@1100 { + compatible = "qcom,pm8150b-vbus-reg"; + status = "disabled"; + reg = <0x1100>; + }; + pm8150b_typec: usb-typec@1500 { compatible = "qcom,pm8150b-usb-typec"; status = "disabled"; diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts index 6c6325c3af59..ba3b5b802954 100644 --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts @@ -409,6 +409,10 @@ &ufs_mem_phy { vdda-pll-max-microamp = <19000>; }; +&pm8150b_vbus { + status = "okay"; +}; + &usb_1_hsphy { status = "okay"; vdda-pll-supply = <&vdd_usb_hs_core>;
Add the required DTS node for the USB VBUS output regulator, which is available on PM8150B. This will provide the VBUS source to connected peripherals. Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++ arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++++ 2 files changed, 10 insertions(+)