| Message ID | 20201013135913.29059-3-georgi.djakov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 599809540f173f572c32a35d712accdc14d6357c |
| Headers | show |
| Series | [1/3] interconnect: Aggregate before setting initial bandwidth | expand |
On Tue, Oct 13, 2020 at 6:59 AM Georgi Djakov <georgi.djakov@linaro.org> wrote: > > Currently if we use sync_state, by default the bandwidth is maxed out, > but in order to set this in hardware, the BCMs (Bus Clock Managers) need > to be initialized first. Move the BCM initialization before creating the > nodes to fix this. > > Fixes: 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> > --- > drivers/interconnect/qcom/sc7180.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/interconnect/qcom/sc7180.c b/drivers/interconnect/qcom/sc7180.c > index bf11b82ed55c..8d9044ed18ab 100644 > --- a/drivers/interconnect/qcom/sc7180.c > +++ b/drivers/interconnect/qcom/sc7180.c > @@ -553,6 +553,9 @@ static int qnoc_probe(struct platform_device *pdev) > return ret; > } > > + for (i = 0; i < qp->num_bcms; i++) > + qcom_icc_bcm_init(qp->bcms[i], &pdev->dev); > + > for (i = 0; i < num_nodes; i++) { > size_t j; > > @@ -576,9 +579,6 @@ static int qnoc_probe(struct platform_device *pdev) > } > data->num_nodes = num_nodes; > > - for (i = 0; i < qp->num_bcms; i++) > - qcom_icc_bcm_init(qp->bcms[i], &pdev->dev); > - > platform_set_drvdata(pdev, qp); > > return 0; Acked-by: Saravana Kannan <saravanak@google.com> -Saravana
diff --git a/drivers/interconnect/qcom/sc7180.c b/drivers/interconnect/qcom/sc7180.c index bf11b82ed55c..8d9044ed18ab 100644 --- a/drivers/interconnect/qcom/sc7180.c +++ b/drivers/interconnect/qcom/sc7180.c @@ -553,6 +553,9 @@ static int qnoc_probe(struct platform_device *pdev) return ret; } + for (i = 0; i < qp->num_bcms; i++) + qcom_icc_bcm_init(qp->bcms[i], &pdev->dev); + for (i = 0; i < num_nodes; i++) { size_t j; @@ -576,9 +579,6 @@ static int qnoc_probe(struct platform_device *pdev) } data->num_nodes = num_nodes; - for (i = 0; i < qp->num_bcms; i++) - qcom_icc_bcm_init(qp->bcms[i], &pdev->dev); - platform_set_drvdata(pdev, qp); return 0;
Currently if we use sync_state, by default the bandwidth is maxed out, but in order to set this in hardware, the BCMs (Bus Clock Managers) need to be initialized first. Move the BCM initialization before creating the nodes to fix this. Fixes: 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> --- drivers/interconnect/qcom/sc7180.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)