[v6,4/4] watchdog: mt8192: add wdt support

Message ID 20201014131936.20584-5-crystal.guo@mediatek.com
State New
Headers show
Series
  • watchdog: mt8192: add wdt support
Related show

Commit Message

Crystal Guo Oct. 14, 2020, 1:19 p.m.
Add support for watchdog device found in MT8192 SoC

Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

---
 drivers/watchdog/mtk_wdt.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.18.0

Comments

Guenter Roeck Jan. 23, 2021, 6:27 p.m. | #1
On Wed, Oct 14, 2020 at 09:19:36PM +0800, Crystal Guo wrote:
> Add support for watchdog device found in MT8192 SoC

> 

> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>

> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> Reviewed-by: Guenter Roeck <linux@roeck-us.net>


FTR, I now added this series to my watchdog-next tree. Hopefully
Wim will pick it up from there.

Ultimately the bindings should be updated to yaml format, but I don't see
the point of holding up the series for that, and the series has been
collecting dust for long enough.

Guenter

> ---

>  drivers/watchdog/mtk_wdt.c | 6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c

> index d6a6393f609d..aef0c2db6a11 100644

> --- a/drivers/watchdog/mtk_wdt.c

> +++ b/drivers/watchdog/mtk_wdt.c

> @@ -11,6 +11,7 @@

>  

>  #include <dt-bindings/reset-controller/mt2712-resets.h>

>  #include <dt-bindings/reset-controller/mt8183-resets.h>

> +#include <dt-bindings/reset-controller/mt8192-resets.h>

>  #include <linux/delay.h>

>  #include <linux/err.h>

>  #include <linux/init.h>

> @@ -76,6 +77,10 @@ static const struct mtk_wdt_data mt8183_data = {

>  	.toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,

>  };

>  

> +static const struct mtk_wdt_data mt8192_data = {

> +	.toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,

> +};

> +

>  static int toprgu_reset_update(struct reset_controller_dev *rcdev,

>  			       unsigned long id, bool assert)

>  {

> @@ -322,6 +327,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {

>  	{ .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },

>  	{ .compatible = "mediatek,mt6589-wdt" },

>  	{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },

> +	{ .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },

>  	{ /* sentinel */ }

>  };

>  MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);

Patch

diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index d6a6393f609d..aef0c2db6a11 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -11,6 +11,7 @@ 
 
 #include <dt-bindings/reset-controller/mt2712-resets.h>
 #include <dt-bindings/reset-controller/mt8183-resets.h>
+#include <dt-bindings/reset-controller/mt8192-resets.h>
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/init.h>
@@ -76,6 +77,10 @@  static const struct mtk_wdt_data mt8183_data = {
 	.toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,
 };
 
+static const struct mtk_wdt_data mt8192_data = {
+	.toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
+};
+
 static int toprgu_reset_update(struct reset_controller_dev *rcdev,
 			       unsigned long id, bool assert)
 {
@@ -322,6 +327,7 @@  static const struct of_device_id mtk_wdt_dt_ids[] = {
 	{ .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
 	{ .compatible = "mediatek,mt6589-wdt" },
 	{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
+	{ .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);