diff mbox series

[v3,01/18] migration/rdma: add the 'migrate_use_rdma_pin_all' function

Message ID 1602908748-43335-2-git-send-email-zhengchuan@huawei.com
State New
Headers show
Series Support Multifd for RDMA migration | expand

Commit Message

Zheng Chuan Oct. 17, 2020, 4:25 a.m. UTC
Signed-off-by: Zhimin Feng <fengzhimin1@huawei.com>
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
---
 migration/migration.c | 9 +++++++++
 migration/migration.h | 1 +
 2 files changed, 10 insertions(+)

Comments

Dr. David Alan Gilbert Nov. 10, 2020, 11:52 a.m. UTC | #1
* Chuan Zheng (zhengchuan@huawei.com) wrote:
> Signed-off-by: Zhimin Feng <fengzhimin1@huawei.com>

> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>

> ---

>  migration/migration.c | 9 +++++++++

>  migration/migration.h | 1 +

>  2 files changed, 10 insertions(+)

> 

> diff --git a/migration/migration.c b/migration/migration.c

> index 0575ecb..64ae417 100644

> --- a/migration/migration.c

> +++ b/migration/migration.c

> @@ -2329,6 +2329,15 @@ bool migrate_use_events(void)

>      return s->enabled_capabilities[MIGRATION_CAPABILITY_EVENTS];

>  }

>  

> +bool migrate_use_rdma_pin_all(void)

> +{

> +    MigrationState *s;

> +

> +    s = migrate_get_current();

> +

> +    return s->enabled_capabilities[MIGRATION_CAPABILITY_RDMA_PIN_ALL];

> +}

> +


I'd omit the 'use_' if you need to respin; but that's fine:


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


>  bool migrate_use_multifd(void)

>  {

>      MigrationState *s;

> diff --git a/migration/migration.h b/migration/migration.h

> index deb411a..74fd790 100644

> --- a/migration/migration.h

> +++ b/migration/migration.h

> @@ -300,6 +300,7 @@ bool migrate_ignore_shared(void);

>  bool migrate_validate_uuid(void);

>  

>  bool migrate_auto_converge(void);

> +bool migrate_use_rdma_pin_all(void);

>  bool migrate_use_multifd(void);

>  bool migrate_pause_before_switchover(void);

>  int migrate_multifd_channels(void);

> -- 

> 1.8.3.1

> 

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff mbox series

Patch

diff --git a/migration/migration.c b/migration/migration.c
index 0575ecb..64ae417 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2329,6 +2329,15 @@  bool migrate_use_events(void)
     return s->enabled_capabilities[MIGRATION_CAPABILITY_EVENTS];
 }
 
+bool migrate_use_rdma_pin_all(void)
+{
+    MigrationState *s;
+
+    s = migrate_get_current();
+
+    return s->enabled_capabilities[MIGRATION_CAPABILITY_RDMA_PIN_ALL];
+}
+
 bool migrate_use_multifd(void)
 {
     MigrationState *s;
diff --git a/migration/migration.h b/migration/migration.h
index deb411a..74fd790 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -300,6 +300,7 @@  bool migrate_ignore_shared(void);
 bool migrate_validate_uuid(void);
 
 bool migrate_auto_converge(void);
+bool migrate_use_rdma_pin_all(void);
 bool migrate_use_multifd(void);
 bool migrate_pause_before_switchover(void);
 int migrate_multifd_channels(void);