[commit] Enable gdb.base/type-opaque.exp for remote targets

Message ID 201107151433.p6FEX6Gv006048@d06av02.portsmouth.uk.ibm.com
State Accepted
Headers show

Commit Message

Ulrich Weigand July 15, 2011, 2:33 p.m.
Hello,

gdb.base/type-opaque.exp was disabled on remote targets because
"No support for downloading shared libraries to a target yet."

This may have been true in the distant past, but these days shared
libraries are supported on remote targets as well.

The following patch re-enables the test everywhere.

Tested on a remote arm-linux-gnueabi target from an x86-linux host.

Committed to mainline.

Bye,
Ulrich

ChangeLog:

	* gdb.base/type-opaque.exp: Use gdb_load_shlibs.  Run test on
	remote targets as well.

Patch

Index: gdb/testsuite/gdb.base/type-opaque.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/type-opaque.exp,v
retrieving revision 1.7
diff -u -p -r1.7 type-opaque.exp
--- gdb/testsuite/gdb.base/type-opaque.exp	1 Jan 2011 15:33:43 -0000	1.7
+++ gdb/testsuite/gdb.base/type-opaque.exp	7 Jul 2011 13:25:36 -0000
@@ -30,12 +30,6 @@  set execsrc "${srcdir}/${subdir}/${srcfi
 
 remote_exec build "rm -f ${binfile}"
 
-# Are we on a target board?  No support for downloading shared libraries
-# to a target yet.
-if ![isnative] then {
-    return 0
-}
-
 # get the value of gcc_compiled
 if [get_compiler_info ${binfile}] {
     return -1
@@ -51,6 +45,7 @@  gdb_exit
 gdb_start
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
+gdb_load_shlibs ${libobj}
 
 if ![runto_main] then {
     fail "Can't run to main"