From patchwork Wed Apr 2 02:04:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 27591 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C5A1120341 for ; Wed, 2 Apr 2014 02:05:22 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id wo20sf38218511obc.10 for ; Tue, 01 Apr 2014 19:05:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=hJHieYefvB/oS/plNO+hd1JREUV4pgWdoiCn0Bn+kXE=; b=WftxiWtEprlQyuCUqCsvS2C9Uwx6aHcXhR696XNMsKYlbepXG4uyylstEHbPOVKsyg EK4Nfqk+j2G4aaLdBGugwq+NbNolZ/cmk2CghRoBzD1G5cMEPeeTRKhmWTzR9KkyMw/U 0h6Csm+Sm4G4I1a69JXz+OyTQ/vFA8zFWaErt5jpaWUggvSy1nTJLFSHLbgRU/1npU1W 6pf39sNGuLQdZ+Ag9+lcJqNxRMn6OJ43Gm3szDROrUwbuiiTG04RgsoZVPtIe13QGWjG hg+ymNj2yFOhcK1rR6Slb94/tWjDVy1A2HuRddOCEr7eTvOLtZ+dp4PIBeax2vmsdfcm CBfA== X-Gm-Message-State: ALoCoQl803QkultEtj9QosbwEarWLNfdHz2PkcI0d2LuKSOcXCY7inYEH9B251jUUYJUZCLxzub+ X-Received: by 10.182.24.134 with SMTP id u6mr15194694obf.24.1396404322294; Tue, 01 Apr 2014 19:05:22 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.93.33 with SMTP id c30ls212701qge.9.gmail; Tue, 01 Apr 2014 19:05:22 -0700 (PDT) X-Received: by 10.52.99.168 with SMTP id er8mr4517284vdb.26.1396404322197; Tue, 01 Apr 2014 19:05:22 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id gs7si147315vdc.182.2014.04.01.19.05.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Apr 2014 19:05:22 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so10878292vcb.18 for ; Tue, 01 Apr 2014 19:05:22 -0700 (PDT) X-Received: by 10.52.65.132 with SMTP id x4mr4459478vds.36.1396404322047; Tue, 01 Apr 2014 19:05:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp284997vcv; Tue, 1 Apr 2014 19:05:21 -0700 (PDT) X-Received: by 10.194.92.177 with SMTP id cn17mr23427176wjb.18.1396404321219; Tue, 01 Apr 2014 19:05:21 -0700 (PDT) Received: from casper.infradead.org (casper.infradead.org. [2001:770:15f::2]) by mx.google.com with ESMTPS id nd8si10894272wic.41.2014.04.01.19.05.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Apr 2014 19:05:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:770:15f::2 as permitted sender) client-ip=2001:770:15f::2; Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WVAY4-0000PE-FS; Wed, 02 Apr 2014 02:05:04 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WVAY1-0005tf-Op; Wed, 02 Apr 2014 02:05:01 +0000 Received: from mail-ig0-f179.google.com ([209.85.213.179]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WVAXx-0005rZ-QR for linux-arm-kernel@lists.infradead.org; Wed, 02 Apr 2014 02:04:58 +0000 Received: by mail-ig0-f179.google.com with SMTP id hl10so2139953igb.6 for ; Tue, 01 Apr 2014 19:04:33 -0700 (PDT) X-Received: by 10.42.53.10 with SMTP id l10mr46081526icg.33.1396404273506; Tue, 01 Apr 2014 19:04:33 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id vu3sm1909156igc.6.2014.04.01.19.04.32 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Apr 2014 19:04:32 -0700 (PDT) From: Alex Elder To: mturquette@linaro.org, bcm@fixthebug.org, mporter@linaro.org Subject: [PATCH v3 1/7] clk: bcm281xx: warn if ccu_wait_bit() fails Date: Tue, 1 Apr 2014 21:04:49 -0500 Message-Id: <1396404296-9390-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1396404296-9390-1-git-send-email-elder@linaro.org> References: <1396404296-9390-1-git-send-email-elder@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140401_220457_895255_4354AD0A X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.179 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index e3d339e..c01d810 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want) return true; udelay(1); } + pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__, + ccu->name, reg_offset, bit, want ? "set" : "clear"); + return false; }