From patchwork Tue Apr 8 09:28:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Newton X-Patchwork-Id: 27932 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f200.google.com (mail-ve0-f200.google.com [209.85.128.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2007220447 for ; Tue, 8 Apr 2014 09:28:35 +0000 (UTC) Received: by mail-ve0-f200.google.com with SMTP id oy12sf1991124veb.7 for ; Tue, 08 Apr 2014 02:28:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:mailing-list :precedence:list-id:list-unsubscribe:list-subscribe:list-archive :list-post:list-help:sender:delivered-to:from:to:subject:date :message-id:x-original-sender:x-original-authentication-results; bh=xuqzZlNBLRckL1yKZAkU3y9RRZpd4aekS+BpwYLCNLE=; b=BkAKwIrV9Hq1RZHFOOyhugVH+/9SUN6H1zXk0oCfZ3kdFxQxH7MBULb9N24VymkXc2 DCXYFJhfaA2COc8RFm2qHahmn5Ri9PkqmInZlg0G9o/IbKKIR3oeLqzwwVbk865hiDa/ ea2Egb1s4nY1IDFi7kmEuI6el0aLwPkEHYRpWIZM4E2qfatACJ13o+Vx66JrMljI9SvE mvOn4eCB9DIHMcbO2jPCbG/VJJUeDvyIAFqgMhJEyO21S62Q+pX+8H+6riXgy1Mfe2D/ Lo5eV988Pa02OQfmvSyN5hdmr44ngrF5LwkStZAl4lR1gHHQGrfhdeD97XbLNt7PzvCD 7xcg== X-Gm-Message-State: ALoCoQkLoS2HW57PGLh/r9bYz3BOgyUgQ6d2+e9R+BXDSvHrjZdNt2KaYFl5PUtRGcf0g6PNKqN9 X-Received: by 10.236.88.210 with SMTP id a58mr1164506yhf.50.1396949314891; Tue, 08 Apr 2014 02:28:34 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.95.66 with SMTP id h60ls140081qge.54.gmail; Tue, 08 Apr 2014 02:28:34 -0700 (PDT) X-Received: by 10.220.163.3 with SMTP id y3mr2303770vcx.7.1396949314748; Tue, 08 Apr 2014 02:28:34 -0700 (PDT) Received: from mail-vc0-x22c.google.com (mail-vc0-x22c.google.com [2607:f8b0:400c:c03::22c]) by mx.google.com with ESMTPS id ya4si293920vec.55.2014.04.08.02.28.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 02:28:34 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c03::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c03::22c; Received: by mail-vc0-f172.google.com with SMTP id la4so515863vcb.17 for ; Tue, 08 Apr 2014 02:28:34 -0700 (PDT) X-Received: by 10.58.1.97 with SMTP id 1mr868445vel.23.1396949314509; Tue, 08 Apr 2014 02:28:34 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp230164vcv; Tue, 8 Apr 2014 02:28:34 -0700 (PDT) X-Received: by 10.67.24.1 with SMTP id ie1mr3098482pad.133.1396949313689; Tue, 08 Apr 2014 02:28:33 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id nm5si760121pbc.509.2014.04.08.02.28.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Apr 2014 02:28:33 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-48890-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 27251 invoked by alias); 8 Apr 2014 09:28:23 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Subscribe: List-Archive: List-Post: , List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 27241 invoked by uid 89); 8 Apr 2014 09:28:22 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f169.google.com X-Received: by 10.194.237.170 with SMTP id vd10mr75862wjc.91.1396949296360; Tue, 08 Apr 2014 02:28:16 -0700 (PDT) From: Will Newton To: libc-alpha@sourceware.org Subject: [PATCH] benchtests: Improve readability of JSON output Date: Tue, 8 Apr 2014 10:28:10 +0100 Message-Id: <1396949290-21346-1-git-send-email-will.newton@linaro.org> X-Original-Sender: will.newton@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c03::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@sourceware.org X-Google-Group-Id: 836684582541 Add a small library to print JSON values and use it to improve the readability of the benchmark output and the readability of the benchmark code. ChangeLog: 2014-04-08 Will Newton * benchtests/Makefile (extra-objs): Add json-lib.o. (bench-func): Tidy up JSON output. * benchtests/bench-skeleton.c: Include json-lib.h. (main): Use JSON library functions to do output of benchmark results. * benchtests/bench-timing-type.c (main): Output the timing type simply, leaving formatting to the user. * benchtests/json-lib.c: New file. * benchtests/json-lib.h: Likewise. --- benchtests/Makefile | 13 ++-- benchtests/bench-skeleton.c | 39 ++++++------ benchtests/bench-timing-type.c | 2 +- benchtests/json-lib.c | 132 +++++++++++++++++++++++++++++++++++++++++ benchtests/json-lib.h | 42 +++++++++++++ 5 files changed, 205 insertions(+), 23 deletions(-) create mode 100644 benchtests/json-lib.c create mode 100644 benchtests/json-lib.h diff --git a/benchtests/Makefile b/benchtests/Makefile index ca635cf..a788082 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -100,6 +100,8 @@ cpp-srcs-left := $(binaries-benchset:=.c) $(binaries-bench:=.c) lib := nonlib include $(patsubst %,$(..)cppflags-iterator.mk,$(cpp-srcs-left)) +extra-objs += json-lib.o + bench-deps := bench-skeleton.c bench-timing.h Makefile run-bench = $(test-wrapper-env) \ @@ -126,9 +128,9 @@ bench-set: $(binaries-benchset) # so one could even execute them individually and process it using any JSON # capable language or tool. bench-func: $(binaries-bench) - { echo "{"; \ - $(timing-type); \ - echo " ,\"functions\": {"; \ + { timing_type=$$($(timing-type)); \ + echo "{\"timing_type\": \"$${timing_type}\","; \ + echo " \"functions\": {"; \ for run in $^; do \ if ! [ "x$${run}" = "x$<" ]; then \ echo ","; \ @@ -136,14 +138,15 @@ bench-func: $(binaries-bench) echo "Running $${run}" >&2; \ $(run-bench) $(DETAILED_OPT); \ done; \ - echo " }"; \ + echo; \ + echo " }"; \ echo "}"; } > $(objpfx)bench.out-tmp; \ if [ -f $(objpfx)bench.out ]; then \ mv -f $(objpfx)bench.out $(objpfx)bench.out.old; \ fi; \ mv -f $(objpfx)bench.out-tmp $(objpfx)bench.out -$(timing-type) $(binaries-bench) $(binaries-benchset): %: %.o \ +$(timing-type) $(binaries-bench) $(binaries-benchset): %: %.o $(objpfx)json-lib.o \ $(sort $(filter $(common-objpfx)lib%,$(link-libc))) \ $(addprefix $(csu-objpfx),start.o) $(+preinit) $(+postinit) $(+link) diff --git a/benchtests/bench-skeleton.c b/benchtests/bench-skeleton.c index 0c7d744..ee37173 100644 --- a/benchtests/bench-skeleton.c +++ b/benchtests/bench-skeleton.c @@ -23,6 +23,7 @@ #include #include #include "bench-timing.h" +#include "json-lib.h" volatile unsigned int dontoptimize = 0; @@ -50,6 +51,7 @@ main (int argc, char **argv) struct timespec runtime; timing_t start, end; bool detailed = false; + json_ctx_t json_ctx; if (argc == 2 && !strcmp (argv[1], "-d")) detailed = true; @@ -64,13 +66,13 @@ main (int argc, char **argv) iters = 1000 * res; + json_init (&json_ctx, 2, stdout); + /* Begin function. */ - printf ("\"%s\": {\n", FUNCNAME); + json_object_begin (&json_ctx, FUNCNAME); for (int v = 0; v < NUM_VARIANTS; v++) { - if (v) - putc (',', stdout); /* Run for approximately DURATION seconds. */ clock_gettime (CLOCK_MONOTONIC_RAW, &runtime); runtime.tv_sec += DURATION; @@ -119,28 +121,31 @@ main (int argc, char **argv) d_total_s = total; d_iters = iters; - printf ("\"%s\": {\n", VARIANT (v)); - printf ("\"duration\": %g, \"iterations\": %g, " - "\"max\": %g, \"min\": %g, \"mean\": %g\n", - d_total_s, d_total_i, max / d_iters, min / d_iters, - d_total_s / d_total_i); + /* Begin variant. */ + json_object_begin (&json_ctx, VARIANT (v)); + + json_attr_double (&json_ctx, "duration", d_total_s); + json_attr_double (&json_ctx, "iterations", d_total_i); + json_attr_double (&json_ctx, "max", max / d_iters); + json_attr_double (&json_ctx, "min", min / d_iters); + json_attr_double (&json_ctx, "mean", d_total_s / d_total_i); if (detailed) { - printf (",\n\"timings\": ["); + json_array_begin (&json_ctx, "timings"); + for (int i = 0; i < NUM_SAMPLES (v); i++) - { - if (i > 0) - putc (',', stdout); - printf ("%g", RESULT (v, i)); - } - puts ("]"); + json_element_double (&json_ctx, RESULT (v, i)); + + json_array_end (&json_ctx); } - puts ("}"); + + /* End variant. */ + json_object_end (&json_ctx); } /* End function. */ - puts ("}"); + json_object_end (&json_ctx); return 0; } diff --git a/benchtests/bench-timing-type.c b/benchtests/bench-timing-type.c index 903a61f..64219ff 100644 --- a/benchtests/bench-timing-type.c +++ b/benchtests/bench-timing-type.c @@ -22,6 +22,6 @@ int main (int argc, char **argv) { - printf ("\"timing-type\": \"%s\"\n", TIMING_TYPE); + puts (TIMING_TYPE); return 0; } diff --git a/benchtests/json-lib.c b/benchtests/json-lib.c new file mode 100644 index 0000000..87f21ae --- /dev/null +++ b/benchtests/json-lib.c @@ -0,0 +1,132 @@ +/* Simple library for printing JSON data. + Copyright (C) 2014 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include + +#include "json-lib.h" + +void +json_init (json_ctx_t *ctx, unsigned int indent_level, FILE *fp) +{ + ctx->indent_level = indent_level; + ctx->fp = fp; + ctx->first_element = true; +} + +static void +do_indent (json_ctx_t *ctx) +{ + char indent_buf[ctx->indent_level + 1]; + + memset (indent_buf, ' ', ctx->indent_level + 1); + indent_buf[ctx->indent_level] = '\0'; + + fputs (indent_buf, ctx->fp); +} + +void +json_object_begin (json_ctx_t *ctx, const char *name) +{ + if (!ctx->first_element) + fprintf (ctx->fp, ",\n"); + + do_indent (ctx); + + fprintf (ctx->fp, "\"%s\": {\n", name); + + ctx->indent_level++; + ctx->first_element = true; +} + +void +json_object_end (json_ctx_t *ctx) +{ + ctx->indent_level--; + ctx->first_element = false; + + fputs ("\n", ctx->fp); + + do_indent (ctx); + + fputs ("}", ctx->fp); +} + +void +json_array_begin (json_ctx_t *ctx, const char *name) +{ + if (!ctx->first_element) + fprintf (ctx->fp, ",\n"); + + do_indent (ctx); + + fprintf (ctx->fp, "\"%s\": [", name); + + ctx->indent_level++; + ctx->first_element = true; +} + +void +json_element_double (json_ctx_t *ctx, double d) +{ + if (!ctx->first_element) + fprintf (ctx->fp, ", %g", d); + else + { + fprintf (ctx->fp, "%g", d); + ctx->first_element = false; + } +} + +void +json_array_end (json_ctx_t *ctx) +{ + ctx->indent_level--; + ctx->first_element = false; + + fputs ("]", ctx->fp); +} + +void +json_attr_string (json_ctx_t *ctx, const char *name, const char *s) +{ + if (!ctx->first_element) + { + fprintf (ctx->fp, ",\n"); + } + + ctx->first_element = false; + + do_indent (ctx); + + fprintf (ctx->fp, "\"%s\": \"%s\"", name, s); +} + +void +json_attr_double (json_ctx_t *ctx, const char *name, double d) +{ + if (!ctx->first_element) + { + fprintf (ctx->fp, ",\n"); + } + + ctx->first_element = false; + + do_indent (ctx); + + fprintf (ctx->fp, "\"%s\": %g", name, d); +} diff --git a/benchtests/json-lib.h b/benchtests/json-lib.h new file mode 100644 index 0000000..3cbbab3 --- /dev/null +++ b/benchtests/json-lib.h @@ -0,0 +1,42 @@ +/* Simple library for printing JSON data. + Copyright (C) 2014 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef __JSON_LIB_H__ +#define __JSON_LIB_H__ + +#include +#include + +struct json_ctx { + FILE *fp; + unsigned int indent_level; + bool first_element; +}; + +typedef struct json_ctx json_ctx_t; + +void json_init (json_ctx_t *ctx, unsigned int indent_level, FILE *fp); +void json_object_begin (json_ctx_t *ctx, const char *name); +void json_object_end (json_ctx_t *ctx); +void json_array_begin (json_ctx_t *ctx, const char *name); +void json_element_double (json_ctx_t *ctx, double d); +void json_array_end (json_ctx_t *ctx); +void json_attr_string (json_ctx_t *ctx, const char *name, const char *s); +void json_attr_double (json_ctx_t *ctx, const char *name, double d); + +#endif