From patchwork Tue Apr 8 21:43:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 28046 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f200.google.com (mail-ie0-f200.google.com [209.85.223.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 092F020553 for ; Tue, 8 Apr 2014 21:46:08 +0000 (UTC) Received: by mail-ie0-f200.google.com with SMTP id lx4sf6853051iec.11 for ; Tue, 08 Apr 2014 14:46:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=VVPQQ5lYaaFNKGTbLz9fPBcga2dGxnwhc0Qa4aMPHaA=; b=J3bDpI+Zf/TxmaPrFYd13d8k3qBF4/Aqkcpw6YlK9UDmT1xRJxt1Uu4UVClf5k3Iam Ayw+7h3C+WmTCzskBh1F6AQIJnuYU+VQY1JRVmPSiG8TA6aUVKnic6IwUNOVeWaaO+ym KLi6rqsa/SerERIEOU3a8jvgpAuuN4S0pU29LWtOUjCgmZC8ralk78FyKYmdDSsqut8m jNPtURAUY9jigpMVsCYSB7y+/EH0qQheq1/aEBQC7JvNrwOFmkjE0ihmd1SLuJCQV+Z6 M8TNonWKTG6pYjIqrVhpnAOPzs2sAs78xP+A8sNUini6rAyWa9aJXD9ZxoWKBgcB9MGb lyxg== X-Gm-Message-State: ALoCoQkIORun4wsNnj0QkpIVkfFIu/3uNG0lngr5BMRnoNyFhPY2qyVdqBmcm2ZwZbQV2yymKarS X-Received: by 10.182.105.1 with SMTP id gi1mr3032893obb.6.1396993568265; Tue, 08 Apr 2014 14:46:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.49.112 with SMTP id p103ls375614qga.41.gmail; Tue, 08 Apr 2014 14:46:08 -0700 (PDT) X-Received: by 10.52.128.231 with SMTP id nr7mr4368071vdb.17.1396993568065; Tue, 08 Apr 2014 14:46:08 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id xt10si645006veb.112.2014.04.08.14.46.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 14:46:08 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id db12so1326082veb.38 for ; Tue, 08 Apr 2014 14:46:08 -0700 (PDT) X-Received: by 10.52.164.237 with SMTP id yt13mr4449826vdb.18.1396993567984; Tue, 08 Apr 2014 14:46:07 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp280053vcv; Tue, 8 Apr 2014 14:46:07 -0700 (PDT) X-Received: by 10.66.249.165 with SMTP id yv5mr7342165pac.79.1396993567299; Tue, 08 Apr 2014 14:46:07 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id my16si1673162pab.197.2014.04.08.14.46.05; Tue, 08 Apr 2014 14:46:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758133AbaDHVp6 (ORCPT + 27 others); Tue, 8 Apr 2014 17:45:58 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:36333 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757776AbaDHVnN (ORCPT ); Tue, 8 Apr 2014 17:43:13 -0400 Received: by mail-ig0-f177.google.com with SMTP id ur14so1641345igb.10 for ; Tue, 08 Apr 2014 14:43:12 -0700 (PDT) X-Received: by 10.50.66.227 with SMTP id i3mr6770998igt.19.1396993392772; Tue, 08 Apr 2014 14:43:12 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id j9sm6126805igu.10.2014.04.08.14.43.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 14:43:12 -0700 (PDT) From: Alex Elder To: mturquette@linaro.org, mporter@linaro.org, bcm@fixthebug.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/7] clk: bcm281xx: warn if ccu_wait_bit() fails Date: Tue, 8 Apr 2014 16:43:39 -0500 Message-Id: <1396993425-30683-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1396993425-30683-1-git-send-email-elder@linaro.org> References: <1396993425-30683-1-git-send-email-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index db11a87..4b4e35a 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want) return true; udelay(1); } + pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__, + ccu->name, reg_offset, bit, want ? "set" : "clear"); + return false; }