ASoC: fsl: Add explicit include of of.h

Message ID 1397560326-28268-1-git-send-email-broonie@kernel.org
State New
Headers show

Commit Message

Mark Brown April 15, 2014, 11:12 a.m.
From: Mark Brown <broonie@linaro.org>

Hopefully fixing a build failure reported by Stephen Rothwell - though
quite why the other OF headers don't include this as well I'm not sure.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 sound/soc/fsl/fsl_ssi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Rothwell April 16, 2014, 2:06 a.m. | #1
Hi Mark,

On Tue, 15 Apr 2014 12:12:06 +0100 Mark Brown <broonie@kernel.org> wrote:
>
> From: Mark Brown <broonie@linaro.org>
> 
> Hopefully fixing a build failure reported by Stephen Rothwell - though
> quite why the other OF headers don't include this as well I'm not sure.

This did not fix the problem.  The declarations (and presumably the
implementations) all depend on CONFIG_OF which is not set for the x86_64
allmodconfig build ...
Mark Brown April 16, 2014, 9:33 p.m. | #2
On Wed, Apr 16, 2014 at 12:06:07PM +1000, Stephen Rothwell wrote:
> On Tue, 15 Apr 2014 12:12:06 +0100 Mark Brown <broonie@kernel.org> wrote:

> > From: Mark Brown <broonie@linaro.org>

> > Hopefully fixing a build failure reported by Stephen Rothwell - though
> > quite why the other OF headers don't include this as well I'm not sure.

> This did not fix the problem.  The declarations (and presumably the
> implementations) all depend on CONFIG_OF which is not set for the x86_64
> allmodconfig build ...

Oh, sorry.  For some reason I thought this was a PowerPC thing.  In any
case a stub is now being provided by OF (which is in my tree
temporarily)

Patch

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 5428a1fda260..2fbbd8416c00 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -40,6 +40,7 @@ 
 #include <linux/delay.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>