From patchwork Fri Apr 18 18:30:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Kryger X-Patchwork-Id: 28648 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A56C42013D for ; Fri, 18 Apr 2014 18:30:30 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id fp1sf6679755pdb.1 for ; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=0yyHGC2NJyvcusC2JNSUl+3aBxGMUGuGFPhQX0ImRLs=; b=B73RlOfjV4lCYIipeBdy/pzvpihk9llGfUeILjX3mIEO+9ttfUZi/U97C1+V3Mr78R siaEP/eYExyP8mHfMDKXX52ntrNHr3+PtBSG3o028P+zFQMO3oqP0kvwkeFQirhg+WzE dO0614wB5e55LeCwbdqknkBb8HewYY3N4mXeXOPuDCJRXMklGHYAcsqET+BRpmIQohBm 64AmUMQRO20YJQMg1oq7J13Os8+RwrfuJ7NF3DqLqnni+Vk1I9k17qAaYdf+ZOKjO/17 BSID+79CQKYwo1bzPSTaCRvf17MDLF1f5fUiQ0FmJ9M7XKWx7SpyY+e/cL+GBnVT8Iq/ EoRA== X-Gm-Message-State: ALoCoQk6NJW8ZRnxQc4tuyMHHDLeLv6e40viXOGqYmYUdDLyCKDBLfsodxoxPiCTTDhdHl7MZDfI X-Received: by 10.67.4.202 with SMTP id cg10mr10612363pad.42.1397845829818; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.20.22 with SMTP id 22ls1551262qgi.63.gmail; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) X-Received: by 10.220.163.3 with SMTP id y3mr15818593vcx.7.1397845829663; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id fn10si5068822vdc.171.2014.04.18.11.30.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Apr 2014 11:30:29 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jz11so3530290veb.11 for ; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) X-Received: by 10.58.23.6 with SMTP id i6mr18703625vef.12.1397845829589; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp130594vcb; Fri, 18 Apr 2014 11:30:29 -0700 (PDT) X-Received: by 10.68.166.36 with SMTP id zd4mr23594321pbb.54.1397845828696; Fri, 18 Apr 2014 11:30:28 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si16763995pbs.242.2014.04.18.11.30.28; Fri, 18 Apr 2014 11:30:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753600AbaDRSaT (ORCPT + 26 others); Fri, 18 Apr 2014 14:30:19 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:56165 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbaDRSaQ (ORCPT ); Fri, 18 Apr 2014 14:30:16 -0400 X-IronPort-AV: E=Sophos;i="4.97,885,1389772800"; d="scan'208";a="25188477" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw2-out.broadcom.com with ESMTP; 18 Apr 2014 11:53:49 -0700 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 18 Apr 2014 11:30:15 -0700 Received: from mail-sj1-12.sj.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.3.174.1; Fri, 18 Apr 2014 11:30:15 -0700 Received: from dhcp-sv1-10-19-114-209.sj.broadcom.com (mps-infra-lab3.sj.broadcom.com [10.19.114.109]) by mail-sj1-12.sj.broadcom.com (Postfix) with ESMTP id 9F08D27A83; Fri, 18 Apr 2014 11:30:15 -0700 (PDT) Received: by dhcp-sv1-10-19-114-209.sj.broadcom.com (Postfix, from userid 1004) id 7EB362520E7E; Fri, 18 Apr 2014 11:30:15 -0700 (PDT) From: Tim Kryger To: Liam Girdwood , Mark Brown CC: Tim Kryger , Linux Kernel Mailing List Subject: [PATCH] regulator: Allow set voltage on fixed regulators Date: Fri, 18 Apr 2014 11:30:10 -0700 Message-ID: <1397845810-17002-1-git-send-email-tim.kryger@linaro.org> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tim.kryger@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , If a regulator consumer requests a voltage range that can be satisfied, the return value should indicate success even if that regulator has a fixed voltage. Since there is already logic to check if the requested voltage range overlaps the allowed range, set REGULATOR_CHANGE_VOLTAGE for regulators with constraints that include a positive voltage. Signed-off-by: Tim Kryger --- drivers/regulator/of_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index ea4f36f..a205d62 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -36,7 +36,7 @@ static void of_get_regulation_constraints(struct device_node *np, constraints->max_uV = be32_to_cpu(*max_uV); /* Voltage change possible? */ - if (constraints->min_uV != constraints->max_uV) + if (constraints->max_uV > 0) constraints->valid_ops_mask |= REGULATOR_CHANGE_VOLTAGE; /* Only one voltage? Then make sure it's set. */ if (min_uV && max_uV && constraints->min_uV == constraints->max_uV)