From patchwork Mon Apr 21 21:11:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 28721 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9378320341 for ; Mon, 21 Apr 2014 21:12:13 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id fb1sf21264930pad.8 for ; Mon, 21 Apr 2014 14:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=8eHStJuDvo4uMGggOCqvikpVc/tmmJqXQZtauDNcLC4=; b=JGcXtDOs4OO6mffbX5JuuiWhDUbTei3uqsxcOL/7q8xkin6PXUU0VfytxseIqk17si kfQTRUgfVKPjHEwDM/RYgA6L1rN2Q9KloYRyMGOis/GWOifUKgHe2l/MYl1jZg9KqZ3G E/CKLUEAvZHfVbXHVX3QeKJrV7TActgtnlZFUPqyURc6ejnZOeVxf2c6DS0gtDmMPR06 6G9TVchYE8XQqUeqZlX57YthkBhMUxRxgdSPZVmN3Zv2p1IFr9ceWSuMkCg8PSUrYEEw z5CpIJA12FU4WOFSwClmvA62qbWoq35KHUNW+I3XLszIt0O6+7o+oShTx3Q4lP/emvLN jFHQ== X-Gm-Message-State: ALoCoQmXfmuAX4nlDEchNFL+A+97DC3b0XWM8273kQo4b2EF0biLk2CLUYWzzAHTbfFAGQQbJTmA X-Received: by 10.68.253.66 with SMTP id zy2mr20183320pbc.1.1398114732826; Mon, 21 Apr 2014 14:12:12 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.48.112 with SMTP id n103ls770214qga.86.gmail; Mon, 21 Apr 2014 14:12:12 -0700 (PDT) X-Received: by 10.52.90.37 with SMTP id bt5mr28387641vdb.7.1398114732700; Mon, 21 Apr 2014 14:12:12 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id vv9si6451137vcb.91.2014.04.21.14.12.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Apr 2014 14:12:12 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jz11so8694553veb.11 for ; Mon, 21 Apr 2014 14:12:12 -0700 (PDT) X-Received: by 10.220.105.4 with SMTP id r4mr2667466vco.27.1398114732599; Mon, 21 Apr 2014 14:12:12 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp318756vcb; Mon, 21 Apr 2014 14:12:11 -0700 (PDT) X-Received: by 10.68.184.66 with SMTP id es2mr40340391pbc.19.1398114731124; Mon, 21 Apr 2014 14:12:11 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dg5si21475539pbc.437.2014.04.21.14.12.10; Mon, 21 Apr 2014 14:12:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598AbaDUVMB (ORCPT + 26 others); Mon, 21 Apr 2014 17:12:01 -0400 Received: from mail-yk0-f173.google.com ([209.85.160.173]:51827 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754473AbaDUVL6 (ORCPT ); Mon, 21 Apr 2014 17:11:58 -0400 Received: by mail-yk0-f173.google.com with SMTP id 10so3803035ykt.4 for ; Mon, 21 Apr 2014 14:11:57 -0700 (PDT) X-Received: by 10.236.156.65 with SMTP id l41mr55127957yhk.9.1398114717698; Mon, 21 Apr 2014 14:11:57 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id d68sm73391492yhc.37.2014.04.21.14.11.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Apr 2014 14:11:56 -0700 (PDT) From: Alex Elder To: mturquette@linaro.org, mporter@linaro.org, bcm@fixthebug.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 RESEND 1/7] clk: bcm281xx: warn if ccu_wait_bit() fails Date: Mon, 21 Apr 2014 16:11:37 -0500 Message-Id: <1398114703-32410-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1398114703-32410-1-git-send-email-elder@linaro.org> References: <1398114703-32410-1-git-send-email-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index db11a87..4b4e35a 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want) return true; udelay(1); } + pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__, + ccu->name, reg_offset, bit, want ? "set" : "clear"); + return false; }