diff mbox series

[v2] tty: serial: imx: remove unneeded break

Message ID 20201020130709.28096-1-trix@redhat.com
State New
Headers show
Series [v2] tty: serial: imx: remove unneeded break | expand

Commit Message

Tom Rix Oct. 20, 2020, 1:07 p.m. UTC 
From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
---

v2: improve commit log

---
 drivers/tty/serial/imx.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Uwe Kleine-König Oct. 26, 2020, 4:32 p.m. UTC | #1 
Hello,

On Tue, Oct 20, 2020 at 06:07:09AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>

> 

> A break is not needed if it is preceded by a return

> 

> Signed-off-by: Tom Rix <trix@redhat.com>


Just for the record: I commented for v1:

> this might be subjective, but I like the break being there for clearity.

> So I object to make a patch to remove them. In case I'm outvoted I'd at

> least want empty lines instead.


Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
diff mbox series

Patch

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 1731d9728865..09703079db7b 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -320,7 +320,6 @@  static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
 	switch (offset) {
 	case UCR1:
 		return sport->ucr1;
-		break;
 	case UCR2:
 		/*
 		 * UCR2_SRST is the only bit in the cached registers that might
@@ -331,16 +330,12 @@  static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
 		if (!(sport->ucr2 & UCR2_SRST))
 			sport->ucr2 = readl(sport->port.membase + offset);
 		return sport->ucr2;
-		break;
 	case UCR3:
 		return sport->ucr3;
-		break;
 	case UCR4:
 		return sport->ucr4;
-		break;
 	case UFCR:
 		return sport->ufcr;
-		break;
 	default:
 		return readl(sport->port.membase + offset);
 	}