| Message ID | 20201013160845.1772-7-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | fix all errors except one reported by dt_binding_check | expand |
Zhen On 10/13/20 11:08 AM, Zhen Lei wrote: > The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is > cmd-gpio. > > arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235: > cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>; > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > index b3c45c046ba5e37..c7a06a9650db2ed 100644 > --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > @@ -24,7 +24,7 @@ properties: > compatible: > const: olpc,xo1.75-ec > > - cmd-gpios: > + cmd-gpio: Preference is gpios not gpio. But Rob H accept or reject Dan
On 2020/10/15 15:12, Lubomir Rintel wrote: > Hi, > > On Wed, Oct 14, 2020 at 12:08:45AM +0800, Zhen Lei wrote: >> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is >> cmd-gpio. >> >> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235: >> cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>; >> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > > Thanks for the patch. > > I've sent out an equivalent one some time ago: > https://lore.kernel.org/lkml/20200925234805.228251-3-lkundrak@v3.sk/ > > In any case, either is fine with me. Geert Uytterhoeven just replied me that the *-gpio form is deprecated. So your patch is the correct one. > > Acked-by: Lubomir Rintel <lkundrak@v3.sk> > >> --- >> Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml >> index b3c45c046ba5e37..c7a06a9650db2ed 100644 >> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml >> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml >> @@ -24,7 +24,7 @@ properties: >> compatible: >> const: olpc,xo1.75-ec >> >> - cmd-gpios: >> + cmd-gpio: >> description: GPIO uspecifier of the CMD pin >> maxItems: 1 >> >> @@ -32,7 +32,7 @@ properties: >> >> required: >> - compatible >> - - cmd-gpios >> + - cmd-gpio >> >> additionalProperties: false >> >> @@ -49,7 +49,7 @@ examples: >> slave { >> compatible = "olpc,xo1.75-ec"; >> spi-cpha; >> - cmd-gpios = <&gpio 155 GPIO_ACTIVE_HIGH>; >> + cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>; >> }; >> }; >> >> -- >> 1.8.3 >> >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > . >
diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml index b3c45c046ba5e37..c7a06a9650db2ed 100644 --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml @@ -24,7 +24,7 @@ properties: compatible: const: olpc,xo1.75-ec - cmd-gpios: + cmd-gpio: description: GPIO uspecifier of the CMD pin maxItems: 1 @@ -32,7 +32,7 @@ properties: required: - compatible - - cmd-gpios + - cmd-gpio additionalProperties: false @@ -49,7 +49,7 @@ examples: slave { compatible = "olpc,xo1.75-ec"; spi-cpha; - cmd-gpios = <&gpio 155 GPIO_ACTIVE_HIGH>; + cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>; }; };
The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is cmd-gpio. arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235: cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>; Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)