From patchwork Mon Apr 21 21:53:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 28750 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 901C62032B for ; Mon, 21 Apr 2014 21:55:43 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id gq1sf30288963obb.6 for ; Mon, 21 Apr 2014 14:55:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=38XG5XmaLOXs3CHh2ilGXGEJ2nlxCREHZirVd0OpYS0=; b=OeuvUeXCj6cNsBveWEAvMA4NcCi5mUaNiykjBYsLjtqY90rVxprCJOv9uhIjgDiacD EHghe6733nuJhwiIk6QAWqwRB5pkaLjAkr01uCwh4XxIOCxeYWUUIAcASHuoiaCtAzlq 9o8Cq4sZeNuPUl49B9dGla5vnC20oeetZLQv7oQSOcYWOxqTVNmsJsrkUNIOcBu2ly8P y3hq85cAoqki5p4Lh9YFlxyCRMVadukK3HRu93lV6zbOob0QIV6K0zMWNTkbDDVIAGXH yY0EWrHWpl0RXwxO3gWtWztAQSJMvO9fT7My5n1pGD0kqVUp4nLioD8EYmvQP3TKmw1l AmCg== X-Gm-Message-State: ALoCoQmL4t97qkD/x1lndhbpCnWNYquM7QOFNxxD+JXVLd4qUDOIGcJwjARZc4af1aE8+dxE8Yjx X-Received: by 10.182.22.133 with SMTP id d5mr20797920obf.27.1398117343158; Mon, 21 Apr 2014 14:55:43 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.24.146 with SMTP id 18ls1636024qgr.58.gmail; Mon, 21 Apr 2014 14:55:43 -0700 (PDT) X-Received: by 10.52.126.107 with SMTP id mx11mr432244vdb.41.1398117342998; Mon, 21 Apr 2014 14:55:42 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id c6si6000678veo.108.2014.04.21.14.55.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Apr 2014 14:55:42 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id lh14so1606019vcb.20 for ; Mon, 21 Apr 2014 14:55:42 -0700 (PDT) X-Received: by 10.52.69.146 with SMTP id e18mr27993699vdu.15.1398117342914; Mon, 21 Apr 2014 14:55:42 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp321099vcb; Mon, 21 Apr 2014 14:55:42 -0700 (PDT) X-Received: by 10.224.97.69 with SMTP id k5mr45008135qan.8.1398117342500; Mon, 21 Apr 2014 14:55:42 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id v10si15963257qat.1.2014.04.21.14.55.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Apr 2014 14:55:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcM9y-0003Bj-JR; Mon, 21 Apr 2014 21:53:54 +0000 Received: from mail-yk0-f182.google.com ([209.85.160.182]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcM9r-0002uc-7N for linux-arm-kernel@lists.infradead.org; Mon, 21 Apr 2014 21:53:47 +0000 Received: by mail-yk0-f182.google.com with SMTP id 142so3938413ykq.27 for ; Mon, 21 Apr 2014 14:53:21 -0700 (PDT) X-Received: by 10.236.160.196 with SMTP id u44mr56240809yhk.39.1398117199514; Mon, 21 Apr 2014 14:53:19 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id t63sm74182258yhm.32.2014.04.21.14.53.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Apr 2014 14:53:19 -0700 (PDT) From: Alex Elder To: bcm@fixthebug.org, mporter@linaro.org Subject: [PATCH v2 01/10] ARM: bcm: use memory accessors for ioremapped area Date: Mon, 21 Apr 2014 16:53:02 -0500 Message-Id: <1398117191-2433-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1398117191-2433-1-git-send-email-elder@linaro.org> References: <1398117191-2433-1-git-send-email-elder@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140421_145347_336408_2B691E9F X-CRM114-Status: GOOD ( 12.79 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.182 listed in list.dnswl.org] Cc: bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The pointer used to pass parameters to an "smc" call is produced through a call to ioremap(). As such, we should be using functions like writel() to access it. Signed-off-by: Alex Elder Reviewed-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/mach-bcm/bcm_kona_smc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c index 5e31e91..d881c72 100644 --- a/arch/arm/mach-bcm/bcm_kona_smc.c +++ b/arch/arm/mach-bcm/bcm_kona_smc.c @@ -79,11 +79,11 @@ static void __bcm_kona_smc(void *info) /* Check map in the bounce area */ BUG_ON(!bridge_data.initialized); - /* Copy one 32 bit word into the bounce area */ - args[0] = data->arg0; - args[1] = data->arg1; - args[2] = data->arg2; - args[3] = data->arg3; + /* Copy the four 32 bit argument values into the bounce area */ + writel_relaxed(data->arg0, args++); + writel_relaxed(data->arg1, args++); + writel_relaxed(data->arg2, args++); + writel(data->arg3, args); /* Flush caches for input data passed to Secure Monitor */ if (data->service_id != SSAPI_BRCM_START_VC_CORE)