diff mbox

[Xen-devel,v4,16/21] MAINTAINERS: Add drivers/passthrough/arm

Message ID 1398172475-27873-17-git-send-email-julien.grall@linaro.org
State Superseded, archived
Headers show

Commit Message

Julien Grall April 22, 2014, 1:14 p.m. UTC 
Add the ARM IOMMU directory to "ARM ARCHITECTURE" part

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>
---
 MAINTAINERS |    1 +
 1 file changed, 1 insertion(+)

Comments

Jan Beulich April 22, 2014, 1:50 p.m. UTC | #1 
>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -134,6 +134,7 @@ F:	xen/drivers/char/dt-uart.c
>  F:	xen/drivers/char/exynos4210-uart.c
>  F:	xen/drivers/char/omap-uart.c
>  F:	xen/drivers/char/pl011.c
> +F:	xen/drivers/passthrough/arm

This needs a trailing slash, I think.

Jan
Julien Grall April 22, 2014, 3:02 p.m. UTC | #2 
Hi Jan,

On 04/22/2014 02:50 PM, Jan Beulich wrote:
>>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -134,6 +134,7 @@ F:	xen/drivers/char/dt-uart.c
>>  F:	xen/drivers/char/exynos4210-uart.c
>>  F:	xen/drivers/char/omap-uart.c
>>  F:	xen/drivers/char/pl011.c
>> +F:	xen/drivers/passthrough/arm
> 
> This needs a trailing slash, I think.

The trailing is not necessary (it works correctly for me). I can add it
for consistency.

While I was testing this patch, I've noticed that get_maintainer.pl is
considering that you maintain the directory passthrough/arm with Ian C.,
Stefano and Tim.
Jan Beulich April 22, 2014, 4:35 p.m. UTC | #3 
>>> On 22.04.14 at 17:02, <julien.grall@linaro.org> wrote:
> On 04/22/2014 02:50 PM, Jan Beulich wrote:
>>>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote:
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -134,6 +134,7 @@ F:	xen/drivers/char/dt-uart.c
>>>  F:	xen/drivers/char/exynos4210-uart.c
>>>  F:	xen/drivers/char/omap-uart.c
>>>  F:	xen/drivers/char/pl011.c
>>> +F:	xen/drivers/passthrough/arm
>> 
>> This needs a trailing slash, I think.
> 
> The trailing is not necessary (it works correctly for me). I can add it
> for consistency.

Please do, to clarify this is a directory.

> While I was testing this patch, I've noticed that get_maintainer.pl is
> considering that you maintain the directory passthrough/arm with Ian C.,
> Stefano and Tim.

Likely because you don't also add

X:	xen/drivers/passthrough/arm/

to the generic IOMMU section.

Jan
Julien Grall April 22, 2014, 6:02 p.m. UTC | #4 
On 04/22/2014 05:35 PM, Jan Beulich wrote:
>>>> On 22.04.14 at 17:02, <julien.grall@linaro.org> wrote:
>> On 04/22/2014 02:50 PM, Jan Beulich wrote:
>>>>>> On 22.04.14 at 15:14, <julien.grall@linaro.org> wrote:
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -134,6 +134,7 @@ F:	xen/drivers/char/dt-uart.c
>>>>  F:	xen/drivers/char/exynos4210-uart.c
>>>>  F:	xen/drivers/char/omap-uart.c
>>>>  F:	xen/drivers/char/pl011.c
>>>> +F:	xen/drivers/passthrough/arm
>>>
>>> This needs a trailing slash, I think.
>>
>> The trailing is not necessary (it works correctly for me). I can add it
>> for consistency.
> 
> Please do, to clarify this is a directory.
> 
>> While I was testing this patch, I've noticed that get_maintainer.pl is
>> considering that you maintain the directory passthrough/arm with Ian C.,
>> Stefano and Tim.
> 
> Likely because you don't also add
> 
> X:	xen/drivers/passthrough/arm/
> 
> to the generic IOMMU section.

Thanks, I use it in the next version.
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 3508f18..4ebb966 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -134,6 +134,7 @@  F:	xen/drivers/char/dt-uart.c
 F:	xen/drivers/char/exynos4210-uart.c
 F:	xen/drivers/char/omap-uart.c
 F:	xen/drivers/char/pl011.c
+F:	xen/drivers/passthrough/arm
 
 CPU POOLS
 M:	Juergen Gross <juergen.gross@ts.fujitsu.com>