From patchwork Tue Apr 22 21:18:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 28836 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 95583203AC for ; Tue, 22 Apr 2014 21:19:04 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id 29sf253830yhl.1 for ; Tue, 22 Apr 2014 14:19:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:date :message-id:subject:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=r9wSFAkKXXIHAdMBLqPsYkU3aTHHTZAEzmiewYWN+qc=; b=W+9YW23rIfJAVKtCH7cncySRlGekt7ck1X66BnenWdjioOaGCQzFMpY/7hR6g1JZJT Kk1zThl9VIzKTjPPXESftX97cWW2M9LoFCaJHJ8JhjGQ0Ibt3uD0XEXoql2K1GQfIB8A QwIPG5fCPWdGAALbggCO5V2ORNwLpX5E4wDzFi+EmoUm5r8+tJLqr5gGQK8+lQlIzqgU 9dptCR5IQDYzjEabuK9MZfMRZQbr74e0qkoSJkASWocysrHieupR+KMtHELG5zS2QXE9 0jcRtusY7blB17t3drUHh1Dp56o6DaHpfqpL+LxCc0i3S4MtEf25nWdkYbrUvtoeS4QC uZnw== X-Gm-Message-State: ALoCoQnjVz0QP9Gj3wAIzGc0ZkNQXpn9EZqYK4jTbQLhIkWtpCRSw+78Rq62Cj+Xx9TM7ufcXfbj X-Received: by 10.58.88.136 with SMTP id bg8mr25842748veb.21.1398201544083; Tue, 22 Apr 2014 14:19:04 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.69 with SMTP id e63ls334960qgd.29.gmail; Tue, 22 Apr 2014 14:19:04 -0700 (PDT) X-Received: by 10.58.123.71 with SMTP id ly7mr41965453veb.11.1398201543982; Tue, 22 Apr 2014 14:19:03 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id m3si7107831vcr.131.2014.04.22.14.19.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Apr 2014 14:19:03 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id db12so71728veb.10 for ; Tue, 22 Apr 2014 14:19:03 -0700 (PDT) X-Received: by 10.58.77.238 with SMTP id v14mr3388945vew.27.1398201543889; Tue, 22 Apr 2014 14:19:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp55385vcb; Tue, 22 Apr 2014 14:19:03 -0700 (PDT) X-Received: by 10.68.135.42 with SMTP id pp10mr47513618pbb.58.1398201543168; Tue, 22 Apr 2014 14:19:03 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qa3si7944672pbb.407.2014.04.22.14.19.02; Tue, 22 Apr 2014 14:19:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756351AbaDVVSj (ORCPT ); Tue, 22 Apr 2014 17:18:39 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41790 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbaDVVSg (ORCPT ); Tue, 22 Apr 2014 17:18:36 -0400 Received: from cpc11-sgyl31-2-0-cust672.sgyl.cable.virginm.net ([94.175.94.161] helo=debutante.sirena.org.uk) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Wci5D-0005tA-5Z; Tue, 22 Apr 2014 21:18:31 +0000 Received: from broonie by debutante.sirena.org.uk with local (Exim 4.82) (envelope-from ) id 1Wci5A-0003Vs-5a; Tue, 22 Apr 2014 22:18:24 +0100 From: Mark Brown To: Michael Hennerich , Dmitry Torokhov Cc: linux-input@vger.kernel.org, linaro-kernel@lists.linaro.org, Mark Brown Date: Tue, 22 Apr 2014 22:18:21 +0100 Message-Id: <1398201501-13470-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 1.9.2 X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mezzanine.sirena.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Subject: [PATCH] Input: ads7877: Remove bitrotted comment X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-input-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: broonie@kernel.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mark Brown While searching for users of spi_async() I found a reference in the ad7877 driver to using it to initiate data transfer from the interrupt handler. However there is no code for this, instead the interrupt handler is a threaded handler and uses spi_sync() instead. Remove the bitrotted comment, though in actual fact the use case mentioned is a great use for spi_async() since it would cut down on latency handling the interrupt by saving us a context switch before we start SPI. This was previously implemented, it was removed in commit b534422b2d11 (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons. It may be better to revert that commit instead. Signed-off-by: Mark Brown --- drivers/input/touchscreen/ad7877.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 6793c85903ae..523865daa1d3 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -210,11 +210,6 @@ static bool gpio3; module_param(gpio3, bool, 0); MODULE_PARM_DESC(gpio3, "If gpio3 is set to 1 AUX3 acts as GPIO3"); -/* - * ad7877_read/write are only used for initial setup and for sysfs controls. - * The main traffic is done using spi_async() in the interrupt handler. - */ - static int ad7877_read(struct spi_device *spi, u16 reg) { struct ser_req *req;