| Message ID | 1398342509-10243-10-git-send-email-peter.griffin@linaro.org |
|---|---|
| State | Accepted |
| Commit | 513199368aa16758088385e17284a6dacad3f869 |
| Headers | show |
On Thu, Apr 24, 2014 at 5:28 AM, Peter Griffin <peter.griffin@linaro.org> wrote: > The LP8788 driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: Milo Kim <milo.kim@ti.com> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 4791af7..ac6bc28 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -393,7 +393,7 @@ config BACKLIGHT_LP855X > > config BACKLIGHT_LP8788 > tristate "Backlight driver for TI LP8788 MFD" > - depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 > + depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM Looks good to me, Acked-by: Bryan Wu <cooloney@gmail.com> > help > This supports TI LP8788 backlight driver. > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 04/24/2014 09:28 PM, Peter Griffin wrote: > The LP8788 driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Thanks! Acked-by: Milo Kim <milo.kim@ti.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Thursday, April 24, 2014 9:28 PM, Peter Griffin wrote: > > The LP8788 driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: Milo Kim <milo.kim@ti.com> > Cc: Jingoo Han <jg1.han@samsung.com> Acked-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 4791af7..ac6bc28 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -393,7 +393,7 @@ config BACKLIGHT_LP855X > > config BACKLIGHT_LP8788 > tristate "Backlight driver for TI LP8788 MFD" > - depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 > + depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM > help > This supports TI LP8788 backlight driver. > > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> The LP8788 driver cannot be successfully built if we don't > enable the PWM subsystem. This patch makes that dependency > explicit in Kconfig and prevents broken randconfig builds. > > Based on Arnd Bergmann patch but split out into seperate > commits per driver based on feedback. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: Milo Kim <milo.kim@ti.com> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 4791af7..ac6bc28 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -393,7 +393,7 @@ config BACKLIGHT_LP855X config BACKLIGHT_LP8788 tristate "Backlight driver for TI LP8788 MFD" - depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 + depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM help This supports TI LP8788 backlight driver.