From patchwork Fri Apr 25 19:15:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 29124 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f197.google.com (mail-pd0-f197.google.com [209.85.192.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 854A3202E6 for ; Fri, 25 Apr 2014 19:15:49 +0000 (UTC) Received: by mail-pd0-f197.google.com with SMTP id r10sf8088583pdi.4 for ; Fri, 25 Apr 2014 12:15:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=JOAVVatAqJYJ8Mwpf/4a2icPbN31XKcFjWHYcXJDSm8=; b=loTMzUMy6HhZkzMWxQTqWzQCPloqWsNiiQDof2GffFIJbVis5TIWK9QXOxa3TyjPF0 /eUnDj8Qn4FaGJ7goBUqKC2TxVI1LSAYQV9G3TkEu5Uv1tdi8sipNdHiZ1w8yPPgtCfZ 59D4tmHY3gizolQci1zvWjlnlk0P1SWsyZeJNR7XR3ZClhS7r4BnAXW9+QiWn/DwzQkL 6qG3y9H9o3DWNLgbFpXD5ZfT5AP7uboB0iOVoPK5MIHz0bU6qox15iSs4d6yjJ+igzZs DgdZJMfCLHa46i+wkdEgRhcvV7+OKgfuUrUYeuqfKBJuF/kM6Sfb+iUsJ2x/ftCNZr0O cNWQ== X-Gm-Message-State: ALoCoQkd/Hpiaf5Su23/V1Z0wZZ3B6t6OHQaEXRkXk68DSRStPmvYUtfK7mOFAKAEsGMVTXkkMdb X-Received: by 10.66.66.196 with SMTP id h4mr4065045pat.22.1398453348557; Fri, 25 Apr 2014 12:15:48 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.23.232 with SMTP id 95ls1822835qgp.68.gmail; Fri, 25 Apr 2014 12:15:48 -0700 (PDT) X-Received: by 10.220.225.5 with SMTP id iq5mr58390vcb.42.1398453348378; Fri, 25 Apr 2014 12:15:48 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id z14si1928912vcf.100.2014.04.25.12.15.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Apr 2014 12:15:48 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id lf12so3080045vcb.13 for ; Fri, 25 Apr 2014 12:15:48 -0700 (PDT) X-Received: by 10.52.90.37 with SMTP id bt5mr6829881vdb.7.1398453348296; Fri, 25 Apr 2014 12:15:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp121273vcb; Fri, 25 Apr 2014 12:15:47 -0700 (PDT) X-Received: by 10.66.246.229 with SMTP id xz5mr9900402pac.119.1398453347510; Fri, 25 Apr 2014 12:15:47 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ug9si5440824pab.171.2014.04.25.12.15.46; Fri, 25 Apr 2014 12:15:47 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754746AbaDYTPm (ORCPT + 3 others); Fri, 25 Apr 2014 15:15:42 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:48595 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbaDYTPg (ORCPT ); Fri, 25 Apr 2014 15:15:36 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s3PJFYEh028064; Fri, 25 Apr 2014 14:15:34 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3PJFYWc001817; Fri, 25 Apr 2014 14:15:34 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Fri, 25 Apr 2014 14:15:34 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3PJFY59017576; Fri, 25 Apr 2014 14:15:34 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Paul Zimmerman , Felipe Balbi Subject: [PATCH 2/3] usb: dwc3: gadget: pretty print link states Date: Fri, 25 Apr 2014 14:15:29 -0500 Message-ID: <1398453330-23081-2-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.9.2.459.g68773ac In-Reply-To: <1398453330-23081-1-git-send-email-balbi@ti.com> References: <1398453330-23081-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , this makes it slightly easier to read link state change interrupt logs. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 44 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index f5adf3f..2406a82 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -302,6 +302,42 @@ static const char *dwc3_gadget_ep_cmd_string(u8 cmd) } } +static const char *dwc3_gadget_link_string(enum dwc3_link_state link_state) +{ + switch (link_state) { + case DWC3_LINK_STATE_U0: + return "U0"; + case DWC3_LINK_STATE_U1: + return "U1"; + case DWC3_LINK_STATE_U2: + return "U2"; + case DWC3_LINK_STATE_U3: + return "U3"; + case DWC3_LINK_STATE_SS_DIS: + return "SS.Disabled"; + case DWC3_LINK_STATE_RX_DET: + return "RX.Detect"; + case DWC3_LINK_STATE_SS_INACT: + return "SS.Inactive"; + case DWC3_LINK_STATE_POLL: + return "Polling"; + case DWC3_LINK_STATE_RECOV: + return "Recovery"; + case DWC3_LINK_STATE_HRESET: + return "Hot Reset"; + case DWC3_LINK_STATE_CMPLY: + return "Compliance"; + case DWC3_LINK_STATE_LPBK: + return "Loopback"; + case DWC3_LINK_STATE_RESET: + return "Reset"; + case DWC3_LINK_STATE_RESUME: + return "Resume"; + default: + return "UNKNOWN link state\n"; + } +} + int dwc3_send_gadget_generic_command(struct dwc3 *dwc, int cmd, u32 param) { u32 timeout = 500; @@ -2449,8 +2485,6 @@ static void dwc3_gadget_linksts_change_interrupt(struct dwc3 *dwc, } } - dwc->link_state = next; - switch (next) { case DWC3_LINK_STATE_U1: if (dwc->speed == USB_SPEED_SUPER) @@ -2468,7 +2502,11 @@ static void dwc3_gadget_linksts_change_interrupt(struct dwc3 *dwc, break; } - dev_vdbg(dwc->dev, "%s link %d\n", __func__, dwc->link_state); + dev_vdbg(dwc->dev, "link change: %s [%d] -> %s [%d]\n", __func__, + dwc3_gadget_link_string(dwc->link_state), + dwc->link_state, dwc3_gadget_link_string(next), next); + + dwc->link_state = next; } static void dwc3_gadget_hibernation_interrupt(struct dwc3 *dwc,