From patchwork Fri Apr 25 19:15:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 29125 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 18643202E6 for ; Fri, 25 Apr 2014 19:15:52 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id w10sf8040518pde.5 for ; Fri, 25 Apr 2014 12:15:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=RA/hzfavn1nAf+SDSY9SBW2P43HoSxkNAp6F3E5s9fE=; b=KhqYX1iHEp38g4k+ZGEpWCBkO83Ya5v+mWSv8Fpm9LgL9+W1JHiF3IcsazoWZSOUW3 7kVtRyfuran5Gm4eGLLZOFDYSWn0knTHhZW+cgOQIGLirIO6IffUTzzW1MvJNHNESg+v 5ruilwqmYPiSsiZLM0TmOiwu+15PLY4pKi9/pm4BOsrgL8AocusNFvj2ChozoNRO8NZx vk1NCOIo5CxiJalr83Goo40/6jszU8KclNH41ZJ0GaR72WzhYbn9Sz7Y2S1HRktXOlQy 269VhAGug/4cxtGfnmVm8bWXraJp2/xpLbf+hCtZYfkwql3ccsWX4YIQ3dVJ7cpNkPFO twpA== X-Gm-Message-State: ALoCoQk0nXapJig+gwfX4vqTLKxq+zKcmWoMA7GZCsso2xhBXDSD2bJOjnDAv6VFkpuu9xhHyMW5 X-Received: by 10.68.202.99 with SMTP id kh3mr5441943pbc.8.1398453352361; Fri, 25 Apr 2014 12:15:52 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.30.163 with SMTP id d32ls1610568qgd.44.gmail; Fri, 25 Apr 2014 12:15:52 -0700 (PDT) X-Received: by 10.221.55.133 with SMTP id vy5mr8056187vcb.17.1398453352099; Fri, 25 Apr 2014 12:15:52 -0700 (PDT) Received: from mail-ve0-f178.google.com (mail-ve0-f178.google.com [209.85.128.178]) by mx.google.com with ESMTPS id vd8si1925258vdc.106.2014.04.25.12.15.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Apr 2014 12:15:52 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.128.178; Received: by mail-ve0-f178.google.com with SMTP id jw12so5182328veb.37 for ; Fri, 25 Apr 2014 12:15:52 -0700 (PDT) X-Received: by 10.52.164.175 with SMTP id yr15mr40886vdb.59.1398453352029; Fri, 25 Apr 2014 12:15:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp121279vcb; Fri, 25 Apr 2014 12:15:51 -0700 (PDT) X-Received: by 10.68.133.229 with SMTP id pf5mr9711253pbb.115.1398453350876; Fri, 25 Apr 2014 12:15:50 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ug9si5440824pab.171.2014.04.25.12.15.50; Fri, 25 Apr 2014 12:15:50 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754539AbaDYTPl (ORCPT + 3 others); Fri, 25 Apr 2014 15:15:41 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:60366 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbaDYTPh (ORCPT ); Fri, 25 Apr 2014 15:15:37 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s3PJFZJm005965; Fri, 25 Apr 2014 14:15:36 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3PJFZd5001831; Fri, 25 Apr 2014 14:15:35 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Fri, 25 Apr 2014 14:15:35 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3PJFZEo024199; Fri, 25 Apr 2014 14:15:35 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Paul Zimmerman , Felipe Balbi Subject: [PATCH 3/3] usb: dwc3: gadget: pretty print Generic CMDs Date: Fri, 25 Apr 2014 14:15:30 -0500 Message-ID: <1398453330-23081-3-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.9.2.459.g68773ac In-Reply-To: <1398453330-23081-1-git-send-email-balbi@ti.com> References: <1398453330-23081-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , this makes it slightly easier to read generic CMD logs. It also helps make sure we're sending proper parameters for each command. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 2406a82..c37c8ff 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -302,6 +302,32 @@ static const char *dwc3_gadget_ep_cmd_string(u8 cmd) } } +static const char *dwc3_gadget_generic_cmd_string(u8 cmd) +{ + switch (cmd) { + case DWC3_DGCMD_SET_LMP: + return "Set LMP"; + case DWC3_DGCMD_SET_PERIODIC_PAR: + return "Set Periodic Parameters"; + case DWC3_DGCMD_XMIT_FUNCTION: + return "Transmit Function Wake Device Notification"; + case DWC3_DGCMD_SET_SCRATCHPAD_ADDR_LO: + return "Set Scratchpad Buffer Array Address Lo"; + case DWC3_DGCMD_SET_SCRATCHPAD_ADDR_HI: + return "Set Scratchpad Buffer Array Address Hi"; + case DWC3_DGCMD_SELECTED_FIFO_FLUSH: + return "Selected FIFO Flush"; + case DWC3_DGCMD_ALL_FIFO_FLUSH: + return "All FIFO Flush"; + case DWC3_DGCMD_SET_ENDPOINT_NRDY: + return "Set Endpoint NRDY"; + case DWC3_DGCMD_RUN_SOC_BUS_LOOPBACK: + return "Run SoC Bus Loopback Test"; + default: + return "UNKNOWN"; + } +} + static const char *dwc3_gadget_link_string(enum dwc3_link_state link_state) { switch (link_state) { @@ -343,6 +369,9 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, int cmd, u32 param) u32 timeout = 500; u32 reg; + dev_vdbg(dwc->dev, "generic cmd '%s' [%d] param %08x\n", + dwc3_gadget_generic_cmd_string(cmd), cmd, param); + dwc3_writel(dwc->regs, DWC3_DGCMDPAR, param); dwc3_writel(dwc->regs, DWC3_DGCMD, cmd | DWC3_DGCMD_CMDACT);