From patchwork Fri Apr 25 19:22:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 29126 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6B6A3202E6 for ; Fri, 25 Apr 2014 19:22:47 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id i4sf23853960oah.0 for ; Fri, 25 Apr 2014 12:22:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=QoEY2I6uHBaec2N7RHnpzqNS9RqRTYZju2ZwXzVbzSk=; b=TtrlYg79aBOmr4vi5lf24WyOfd1N+9aIN/EnmQRWxPApn9HCQPZCpThkalNsWK1/dk H7MPFFFwI0NwJzLwI8lECv5FBBpKUDU11P1heQL39Tw7l8+lvD7CrueX0+ayZdWv5P5U 7COJGqq5o2NkSoJ/QRg3voKapuav5ZPxnFB0Ujhll4xnZMi8LWNS3E18x+zQfHrTg+Wh iMV801I0X+g2oowBsSPuFsoCI5HACC/h72APKQ/HzsYmrbDI5HPxyazl+3xBIXheQvvj tu6Eg+SvVTQwQbvg6ZccY0rem8clMpM0k0yWIjLrOx/zss8V+T4nLBykZb7okWjU+S/r OYcA== X-Gm-Message-State: ALoCoQnS7jF78U6u21xr6Dq6p777dBgbJ2AHDUBrH7Tp0hsSTfdT+yY8P3R6nF8wGSnSZdkiNlO1 X-Received: by 10.182.213.37 with SMTP id np5mr5546026obc.36.1398453766969; Fri, 25 Apr 2014 12:22:46 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.31.225 with SMTP id f88ls1696676qgf.65.gmail; Fri, 25 Apr 2014 12:22:46 -0700 (PDT) X-Received: by 10.52.2.229 with SMTP id 5mr3446258vdx.24.1398453766709; Fri, 25 Apr 2014 12:22:46 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id sr19si1935032vcb.71.2014.04.25.12.22.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Apr 2014 12:22:46 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jz11so5168008veb.39 for ; Fri, 25 Apr 2014 12:22:46 -0700 (PDT) X-Received: by 10.58.201.5 with SMTP id jw5mr7902417vec.6.1398453766630; Fri, 25 Apr 2014 12:22:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp121680vcb; Fri, 25 Apr 2014 12:22:45 -0700 (PDT) X-Received: by 10.68.211.233 with SMTP id nf9mr9888380pbc.29.1398453764945; Fri, 25 Apr 2014 12:22:44 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vv4si5450672pbc.279.2014.04.25.12.22.44; Fri, 25 Apr 2014 12:22:44 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbaDYTWm (ORCPT + 3 others); Fri, 25 Apr 2014 15:22:42 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:40998 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbaDYTWl (ORCPT ); Fri, 25 Apr 2014 15:22:41 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s3PJMenq007888; Fri, 25 Apr 2014 14:22:40 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3PJMekd006696; Fri, 25 Apr 2014 14:22:40 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Fri, 25 Apr 2014 14:22:39 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s3PJMdBR009420; Fri, 25 Apr 2014 14:22:39 -0500 Date: Fri, 25 Apr 2014 14:22:38 -0500 From: Felipe Balbi To: Felipe Balbi CC: Linux USB Mailing List , Paul Zimmerman Subject: Re: [PATCH 2/3] usb: dwc3: gadget: pretty print link states Message-ID: <20140425192238.GH29632@saruman.home> Reply-To: References: <1398453330-23081-1-git-send-email-balbi@ti.com> <1398453330-23081-2-git-send-email-balbi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1398453330-23081-2-git-send-email-balbi@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Fri, Apr 25, 2014 at 02:15:29PM -0500, Felipe Balbi wrote: > this makes it slightly easier to read link state > change interrupt logs. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/dwc3/gadget.c | 44 +++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 41 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index f5adf3f..2406a82 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -302,6 +302,42 @@ static const char *dwc3_gadget_ep_cmd_string(u8 cmd) > } > } > > +static const char *dwc3_gadget_link_string(enum dwc3_link_state link_state) > +{ > + switch (link_state) { > + case DWC3_LINK_STATE_U0: > + return "U0"; > + case DWC3_LINK_STATE_U1: > + return "U1"; > + case DWC3_LINK_STATE_U2: > + return "U2"; > + case DWC3_LINK_STATE_U3: > + return "U3"; > + case DWC3_LINK_STATE_SS_DIS: > + return "SS.Disabled"; > + case DWC3_LINK_STATE_RX_DET: > + return "RX.Detect"; > + case DWC3_LINK_STATE_SS_INACT: > + return "SS.Inactive"; > + case DWC3_LINK_STATE_POLL: > + return "Polling"; > + case DWC3_LINK_STATE_RECOV: > + return "Recovery"; > + case DWC3_LINK_STATE_HRESET: > + return "Hot Reset"; > + case DWC3_LINK_STATE_CMPLY: > + return "Compliance"; > + case DWC3_LINK_STATE_LPBK: > + return "Loopback"; > + case DWC3_LINK_STATE_RESET: > + return "Reset"; > + case DWC3_LINK_STATE_RESUME: > + return "Resume"; > + default: > + return "UNKNOWN link state\n"; > + } > +} > + > int dwc3_send_gadget_generic_command(struct dwc3 *dwc, int cmd, u32 param) > { > u32 timeout = 500; > @@ -2449,8 +2485,6 @@ static void dwc3_gadget_linksts_change_interrupt(struct dwc3 *dwc, > } > } > > - dwc->link_state = next; > - > switch (next) { > case DWC3_LINK_STATE_U1: > if (dwc->speed == USB_SPEED_SUPER) > @@ -2468,7 +2502,11 @@ static void dwc3_gadget_linksts_change_interrupt(struct dwc3 *dwc, > break; > } > > - dev_vdbg(dwc->dev, "%s link %d\n", __func__, dwc->link_state); > + dev_vdbg(dwc->dev, "link change: %s [%d] -> %s [%d]\n", __func__, don't you hate when you think you've committed something but in reality you didn't ? grrrrr 8<---------------------------------------------------------------------------- >From e57ebc1db6ef796124b69abca044a373b9110a47 Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Tue, 22 Apr 2014 13:20:12 -0500 Subject: [PATCH] usb: dwc3: gadget: pretty print link states this makes it slightly easier to read link state change interrupt logs. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 44 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index f5adf3f..9a8ae39 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -302,6 +302,42 @@ static const char *dwc3_gadget_ep_cmd_string(u8 cmd) } } +static const char *dwc3_gadget_link_string(enum dwc3_link_state link_state) +{ + switch (link_state) { + case DWC3_LINK_STATE_U0: + return "U0"; + case DWC3_LINK_STATE_U1: + return "U1"; + case DWC3_LINK_STATE_U2: + return "U2"; + case DWC3_LINK_STATE_U3: + return "U3"; + case DWC3_LINK_STATE_SS_DIS: + return "SS.Disabled"; + case DWC3_LINK_STATE_RX_DET: + return "RX.Detect"; + case DWC3_LINK_STATE_SS_INACT: + return "SS.Inactive"; + case DWC3_LINK_STATE_POLL: + return "Polling"; + case DWC3_LINK_STATE_RECOV: + return "Recovery"; + case DWC3_LINK_STATE_HRESET: + return "Hot Reset"; + case DWC3_LINK_STATE_CMPLY: + return "Compliance"; + case DWC3_LINK_STATE_LPBK: + return "Loopback"; + case DWC3_LINK_STATE_RESET: + return "Reset"; + case DWC3_LINK_STATE_RESUME: + return "Resume"; + default: + return "UNKNOWN link state\n"; + } +} + int dwc3_send_gadget_generic_command(struct dwc3 *dwc, int cmd, u32 param) { u32 timeout = 500; @@ -2449,8 +2485,6 @@ static void dwc3_gadget_linksts_change_interrupt(struct dwc3 *dwc, } } - dwc->link_state = next; - switch (next) { case DWC3_LINK_STATE_U1: if (dwc->speed == USB_SPEED_SUPER) @@ -2468,7 +2502,11 @@ static void dwc3_gadget_linksts_change_interrupt(struct dwc3 *dwc, break; } - dev_vdbg(dwc->dev, "%s link %d\n", __func__, dwc->link_state); + dev_vdbg(dwc->dev, "link change: %s [%d] -> %s [%d]\n", + dwc3_gadget_link_string(dwc->link_state), + dwc->link_state, dwc3_gadget_link_string(next), next); + + dwc->link_state = next; } static void dwc3_gadget_hibernation_interrupt(struct dwc3 *dwc,