diff mbox series

mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST

Message ID 20200925164323.29843-1-rdunlap@infradead.org
State New
Headers show
Series mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST | expand

Commit Message

Randy Dunlap Sept. 25, 2020, 4:43 p.m. UTC
Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not
set/enabled. This can happen when COMPILE_TEST is set/enabled.

ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mmc/host/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 25, 2020, 5:04 p.m. UTC | #1
On Fri, Sep 25, 2020 at 09:43:23AM -0700, Randy Dunlap wrote:
> Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not

> set/enabled. This can happen when COMPILE_TEST is set/enabled.

> 

> ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> 

> Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> Cc: Kevin Hilman <khilman@baylibre.com>

> Cc: linux-amlogic@lists.infradead.org

> Cc: linux-arm-kernel@lists.infradead.org

> Cc: Ulf Hansson <ulf.hansson@linaro.org>

> Cc: linux-mmc@vger.kernel.org

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> ---

>  drivers/mmc/host/Kconfig |    1 +

>  1 file changed, 1 insertion(+)

> 

> --- linux-next-20200925.orig/drivers/mmc/host/Kconfig

> +++ linux-next-20200925/drivers/mmc/host/Kconfig

> @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC

>  config MMC_MESON_GX

>  	tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"

>  	depends on ARCH_MESON|| COMPILE_TEST

> +	depends on COMMON_CLK


I received a report from kbuild about this when I posted the patchset
but somehow I was not able to reproduce it... or I skipped this for
reason I do not remember now, my bad.

Anyway, thanks for fixing, looks ok:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>


Also please for the credits (as Kbuild did report it to me):
Reported-by: kernel test robot <lkp@intel.com>

Best regards,
Krzysztof

>  	help

>  	  This selects support for the Amlogic SD/MMC Host Controller

>  	  found on the S905/GX*/AXG family of SoCs.  This controller is
Ulf Hansson Sept. 28, 2020, 10:34 a.m. UTC | #2
On Fri, 25 Sep 2020 at 18:43, Randy Dunlap <rdunlap@infradead.org> wrote:
>

> Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not

> set/enabled. This can happen when COMPILE_TEST is set/enabled.

>

> ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

> ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!

>

> Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> Cc: Kevin Hilman <khilman@baylibre.com>

> Cc: linux-amlogic@lists.infradead.org

> Cc: linux-arm-kernel@lists.infradead.org

> Cc: Ulf Hansson <ulf.hansson@linaro.org>

> Cc: linux-mmc@vger.kernel.org

> Cc: Krzysztof Kozlowski <krzk@kernel.org>


Applied for next, thanks!

Kind regards
Uffe


> ---

>  drivers/mmc/host/Kconfig |    1 +

>  1 file changed, 1 insertion(+)

>

> --- linux-next-20200925.orig/drivers/mmc/host/Kconfig

> +++ linux-next-20200925/drivers/mmc/host/Kconfig

> @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC

>  config MMC_MESON_GX

>         tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"

>         depends on ARCH_MESON|| COMPILE_TEST

> +       depends on COMMON_CLK

>         help

>           This selects support for the Amlogic SD/MMC Host Controller

>           found on the S905/GX*/AXG family of SoCs.  This controller is
diff mbox series

Patch

--- linux-next-20200925.orig/drivers/mmc/host/Kconfig
+++ linux-next-20200925/drivers/mmc/host/Kconfig
@@ -425,6 +425,7 @@  config MMC_SDHCI_IPROC
 config MMC_MESON_GX
 	tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"
 	depends on ARCH_MESON|| COMPILE_TEST
+	depends on COMMON_CLK
 	help
 	  This selects support for the Amlogic SD/MMC Host Controller
 	  found on the S905/GX*/AXG family of SoCs.  This controller is