| Message ID | 20200915084033.2827009-1-yanaijie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: gdth: make option_setup() static | expand |
Jason, > This addresses the following sparse warning: > > drivers/scsi/gdth.c:3229:12: warning: symbol 'option_setup' was not > declared. Should it be static? drivers/scsi/gdth.c:3229:19: error: ‘option_setup’ defined but not used [-Werror=unused-function] 3229 | static int __init option_setup(char *str) | ^~~~~~~~~~~~ cc1: all warnings being treated as errors -- Martin K. Petersen Oracle Linux Engineering
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index dc0e17729acf..0519d3fa43d4 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -3226,7 +3226,7 @@ static void __init internal_setup(char *str,int *ints) } } -int __init option_setup(char *str) +static int __init option_setup(char *str) { int ints[MAXHA]; char *cur = str;
This addresses the following sparse warning: drivers/scsi/gdth.c:3229:12: warning: symbol 'option_setup' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/gdth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)