diff mbox series

scsi: target: tcmu: add a missing newline when printing parameters

Message ID 1599132573-33818-1-git-send-email-wangxiongfeng2@huawei.com
State New
Headers show
Series scsi: target: tcmu: add a missing newline when printing parameters | expand

Commit Message

Xiongfeng Wang Sept. 3, 2020, 11:29 a.m. UTC
When I cat module paramter 'global_max_data_area_mb' by sysfs, it
displays as follows. It's better to add a newline for easy reading.

root@(none):/# cat /sys/module/target_core_user/parameters/global_max_data_area_mb
2048noneroot@(none):/#

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
 drivers/target/target_core_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 16, 2020, 12:19 a.m. UTC | #1
Xiongfeng,

> When I cat module paramter 'global_max_data_area_mb' by sysfs, it

> displays as follows. It's better to add a newline for easy reading.


Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Sept. 22, 2020, 3:56 a.m. UTC | #2
On Thu, 3 Sep 2020 19:29:33 +0800, Xiongfeng Wang wrote:

> When I cat module paramter 'global_max_data_area_mb' by sysfs, it

> displays as follows. It's better to add a newline for easy reading.

> 

> root@(none):/# cat /sys/module/target_core_user/parameters/global_max_data_area_mb

> 2048noneroot@(none):/#


Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: target: tcmu: Add missing newline when printing parameters
      https://git.kernel.org/mkp/scsi/c/6d70cb343484

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 9b75923..9775670 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -242,7 +242,7 @@  static int tcmu_set_global_max_data_area(const char *str,
 static int tcmu_get_global_max_data_area(char *buffer,
 					 const struct kernel_param *kp)
 {
-	return sprintf(buffer, "%d", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
+	return sprintf(buffer, "%d\n", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
 }
 
 static const struct kernel_param_ops tcmu_global_max_data_area_op = {