| Message ID | d1dd0ddd-3143-5777-1c63-195e1a32f237@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] phy: fix USB_LGM_PHY warning & build errors | expand |
Ping. Still seeing this in linux-next. On 9/17/20 10:51 AM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix a Kconfig warning that is causing lots of build errors > when USB_SUPPORT is not set. > > USB_PHY depends on USB_SUPPORT but "select" doesn't care about > dependencies, so this driver should also depend on USB_SUPPORT. > It should not select USB_SUPPORT. > > WARNING: unmet direct dependencies detected for USB_PHY > Depends on [n]: USB_SUPPORT [=n] > Selected by [m]: > - USB_LGM_PHY [=m] > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Li Yin <yin1.li@intel.com> > Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: Vinod Koul <vkoul@kernel.org> > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200917.orig/drivers/phy/Kconfig > +++ linux-next-20200917/drivers/phy/Kconfig > @@ -51,6 +51,7 @@ config PHY_XGENE > > config USB_LGM_PHY > tristate "INTEL Lightning Mountain USB PHY Driver" > + depends on USB_SUPPORT > select USB_PHY > select REGULATOR > select REGULATOR_FIXED_VOLTAGE > -- ~Randy
Hi Randy, Thank you for the report, surely will fix it. Regards Vadivel On 21/9/2020 11:45 pm, Randy Dunlap wrote: > Ping. Still seeing this in linux-next. > > On 9/17/20 10:51 AM, Randy Dunlap wrote: >> From: Randy Dunlap <rdunlap@infradead.org> >> >> Fix a Kconfig warning that is causing lots of build errors >> when USB_SUPPORT is not set. >> >> USB_PHY depends on USB_SUPPORT but "select" doesn't care about >> dependencies, so this driver should also depend on USB_SUPPORT. >> It should not select USB_SUPPORT. >> >> WARNING: unmet direct dependencies detected for USB_PHY >> Depends on [n]: USB_SUPPORT [=n] >> Selected by [m]: >> - USB_LGM_PHY [=m] >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Li Yin <yin1.li@intel.com> >> Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com> >> Cc: Kishon Vijay Abraham I <kishon@ti.com> >> Cc: Vinod Koul <vkoul@kernel.org> >> --- >> drivers/phy/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20200917.orig/drivers/phy/Kconfig >> +++ linux-next-20200917/drivers/phy/Kconfig >> @@ -51,6 +51,7 @@ config PHY_XGENE >> >> config USB_LGM_PHY >> tristate "INTEL Lightning Mountain USB PHY Driver" >> + depends on USB_SUPPORT >> select USB_PHY >> select REGULATOR >> select REGULATOR_FIXED_VOLTAGE >> > >
On 17-09-20, 10:51, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix a Kconfig warning that is causing lots of build errors > when USB_SUPPORT is not set. > > USB_PHY depends on USB_SUPPORT but "select" doesn't care about > dependencies, so this driver should also depend on USB_SUPPORT. > It should not select USB_SUPPORT. > > WARNING: unmet direct dependencies detected for USB_PHY > Depends on [n]: USB_SUPPORT [=n] > Selected by [m]: > - USB_LGM_PHY [=m] Applied, thanks -- ~Vinod
--- linux-next-20200917.orig/drivers/phy/Kconfig +++ linux-next-20200917/drivers/phy/Kconfig @@ -51,6 +51,7 @@ config PHY_XGENE config USB_LGM_PHY tristate "INTEL Lightning Mountain USB PHY Driver" + depends on USB_SUPPORT select USB_PHY select REGULATOR select REGULATOR_FIXED_VOLTAGE