arm: bcm281xx: Add CONFIG_SYS_GENERIC_BOARD

Message ID 1400102289-2438-1-git-send-email-srae@broadcom.com
State Accepted
Commit aed39f354eb663bce7bfbf54c89397b14da2ed64
Headers show

Commit Message

Steve Rae May 14, 2014, 9:18 p.m.
convert to generic board

Signed-off-by: Steve Rae <srae@broadcom.com>
---

 include/configs/bcm28155_ap.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Albert ARIBAUD June 9, 2014, 7:16 a.m. | #1
Hi Steve,

On Wed, 14 May 2014 14:18:09 -0700, Steve Rae <srae@broadcom.com> wrote:

> convert to generic board
> 
> Signed-off-by: Steve Rae <srae@broadcom.com>
> ---

Has this been tested on hardware, or just build-tested?

Amicalement,
Steve Rae June 9, 2014, 4:17 p.m. | #2
On 14-06-09 12:16 AM, Albert ARIBAUD wrote:
> Hi Steve,
>
> On Wed, 14 May 2014 14:18:09 -0700, Steve Rae<srae@broadcom.com>  wrote:
>
>> >convert to generic board
>> >
>> >Signed-off-by: Steve Rae<srae@broadcom.com>
>> >---
> Has this been tested on hardware, or just build-tested?
This generic board change has been tested on hardware.
Thanks, Steve
>
> Amicalement,
> -- Albert.
Albert ARIBAUD June 9, 2014, 6:51 p.m. | #3
Hi Steve,

On Mon, 9 Jun 2014 09:17:35 -0700, Steve Rae <srae@broadcom.com> wrote:

> 
> 
> On 14-06-09 12:16 AM, Albert ARIBAUD wrote:
> > Hi Steve,
> >
> > On Wed, 14 May 2014 14:18:09 -0700, Steve Rae<srae@broadcom.com>  wrote:
> >
> >> >convert to generic board
> >> >
> >> >Signed-off-by: Steve Rae<srae@broadcom.com>
> >> >---
> > Has this been tested on hardware, or just build-tested?
> This generic board change has been tested on hardware.
> Thanks, Steve

Thanks! I'll pull the change in, then.

Amicalement,
Albert ARIBAUD June 10, 2014, 11:20 a.m. | #4
Hi Steve,

On Wed, 14 May 2014 14:18:09 -0700, Steve Rae <srae@broadcom.com> wrote:

> convert to generic board
> 
> Signed-off-by: Steve Rae <srae@broadcom.com>
> ---
> 
>  include/configs/bcm28155_ap.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/bcm28155_ap.h b/include/configs/bcm28155_ap.h
> index e93b855..bf09939 100644
> --- a/include/configs/bcm28155_ap.h
> +++ b/include/configs/bcm28155_ap.h
> @@ -14,6 +14,7 @@
>  #define CONFIG_ARMV7
>  #define CONFIG_KONA
>  #define CONFIG_SKIP_LOWLEVEL_INIT
> +#define CONFIG_SYS_GENERIC_BOARD
>  
>  /*
>   * Memory configuration

Applied to u-boot-arm/master, thanks!

Amicalement,
Steve Rae June 12, 2014, 5:52 p.m. | #5
On 14-06-10 04:20 AM, Albert ARIBAUD wrote:
> Hi Steve,
>
> On Wed, 14 May 2014 14:18:09 -0700, Steve Rae <srae@broadcom.com> wrote:
>
>> convert to generic board
>>
>> Signed-off-by: Steve Rae <srae@broadcom.com>
>> ---
>>
>>   include/configs/bcm28155_ap.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/bcm28155_ap.h b/include/configs/bcm28155_ap.h
>> index e93b855..bf09939 100644
>> --- a/include/configs/bcm28155_ap.h
>> +++ b/include/configs/bcm28155_ap.h
>> @@ -14,6 +14,7 @@
>>   #define CONFIG_ARMV7
>>   #define CONFIG_KONA
>>   #define CONFIG_SKIP_LOWLEVEL_INIT
>> +#define CONFIG_SYS_GENERIC_BOARD
>>
>>   /*
>>    * Memory configuration
>
> Applied to u-boot-arm/master, thanks!
>
> Amicalement,
>

( sorry - I am uncertain of the process... )
I am hoping this will get picked up in the u-boot/master branch (soon) 
!?!?!?
Thanks, Steve
Tom Rini June 14, 2014, 11:39 p.m. | #6
On Thu, Jun 12, 2014 at 10:52:37AM -0700, Steve Rae wrote:
 
> On 14-06-10 04:20 AM, Albert ARIBAUD wrote:
> >Hi Steve,
> >
> >On Wed, 14 May 2014 14:18:09 -0700, Steve Rae <srae@broadcom.com> wrote:
> >
> >>convert to generic board
> >>
> >>Signed-off-by: Steve Rae <srae@broadcom.com>
> >>---
> >>
> >>  include/configs/bcm28155_ap.h | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >>diff --git a/include/configs/bcm28155_ap.h b/include/configs/bcm28155_ap.h
> >>index e93b855..bf09939 100644
> >>--- a/include/configs/bcm28155_ap.h
> >>+++ b/include/configs/bcm28155_ap.h
> >>@@ -14,6 +14,7 @@
> >>  #define CONFIG_ARMV7
> >>  #define CONFIG_KONA
> >>  #define CONFIG_SKIP_LOWLEVEL_INIT
> >>+#define CONFIG_SYS_GENERIC_BOARD
> >>
> >>  /*
> >>   * Memory configuration
> >
> >Applied to u-boot-arm/master, thanks!
> >
> >Amicalement,
> >
> 
> ( sorry - I am uncertain of the process... )
> I am hoping this will get picked up in the u-boot/master branch
> (soon) !?!?!?

Next u-boot-arm pull request will have it and I know Albert will do one
more at least before the release :)

Patch

diff --git a/include/configs/bcm28155_ap.h b/include/configs/bcm28155_ap.h
index e93b855..bf09939 100644
--- a/include/configs/bcm28155_ap.h
+++ b/include/configs/bcm28155_ap.h
@@ -14,6 +14,7 @@ 
 #define CONFIG_ARMV7
 #define CONFIG_KONA
 #define CONFIG_SKIP_LOWLEVEL_INIT
+#define CONFIG_SYS_GENERIC_BOARD
 
 /*
  * Memory configuration