[2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality

Message ID 1400590021-15422-3-git-send-email-m.szyprowski@samsung.com
State New
Headers show

Commit Message

Marek Szyprowski May 20, 2014, 12:46 p.m.
This patch adds device tree nodes necessary to enable USB support on
universalc210 board, this includes UDC controller (USB gadget) as well
as EHCI and OHCI host ports. LDO3 and LDO8 regulators are switched to
always on mode until EHCI and OHCI drivers will support them correctly.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Tomasz Figa May 20, 2014, 10:48 p.m. | #1
Hi Marek,

On 20.05.2014 14:46, Marek Szyprowski wrote:
> This patch adds device tree nodes necessary to enable USB support on
> universalc210 board, this includes UDC controller (USB gadget) as well
> as EHCI and OHCI host ports. LDO3 and LDO8 regulators are switched to
> always on mode until EHCI and OHCI drivers will support them correctly.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4210-universal_c210.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index 9296dee10e26..0a32b396306c 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -68,6 +68,12 @@
>  		enable-active-high;
>  	};
>  
> +	hsotg@12480000 {
> +		vusb_d-supply = <&ldo3_reg>;
> +		vusb_a-supply = <&ldo8_reg>;
> +		status = "okay";
> +	};
> +
>  	sdhci_emmc: sdhci@12510000 {
>  		bus-width = <8>;
>  		non-removable;
> @@ -77,6 +83,18 @@
>  		status = "okay";
>  	};
>  
> +	ehci@12580000 {
> +		status = "okay";

Shouldn't you also enable applicable ports here, so that required PHYs
are configured?

> +	};
> +
> +	ohci@12590000 {
> +		status = "okay";

Ditto.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 9296dee10e26..0a32b396306c 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -68,6 +68,12 @@ 
 		enable-active-high;
 	};
 
+	hsotg@12480000 {
+		vusb_d-supply = <&ldo3_reg>;
+		vusb_a-supply = <&ldo8_reg>;
+		status = "okay";
+	};
+
 	sdhci_emmc: sdhci@12510000 {
 		bus-width = <8>;
 		non-removable;
@@ -77,6 +83,18 @@ 
 		status = "okay";
 	};
 
+	ehci@12580000 {
+		status = "okay";
+	};
+
+	ohci@12590000 {
+		status = "okay";
+	};
+
+	exynos-usbphy@125B0000 {
+		status = "okay";
+	};
+
 	serial@13800000 {
 		status = "okay";
 	};
@@ -216,6 +234,7 @@ 
 					regulator-name = "VUSB+MIPI_1.1V";
 					regulator-min-microvolt = <1100000>;
 					regulator-max-microvolt = <1100000>;
+					regulator-always-on;
 				};
 
 				ldo4_reg: LDO4 {
@@ -246,6 +265,7 @@ 
 					regulator-name = "VUSB+VDAC_3.3V";
 					regulator-min-microvolt = <3300000>;
 					regulator-max-microvolt = <3300000>;
+					regulator-always-on;
 				};
 
 				ldo9_reg: LDO9 {