diff mbox series

[v4,07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

Message ID 20200916061335.14045-8-ani@anisinha.ca
State Superseded
Headers show
Series i440fx/acpi: addition of feature and bug fixes. | expand

Commit Message

Ani Sinha Sept. 16, 2020, 6:13 a.m. UTC
This change adds a new unit test for the global flag
'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci
bridges in i440fx. The flag can be used to turn off acpi based hotplug support
for all pci bridges.

Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
 tests/qtest/bios-tables-test.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Igor Mammedov Sept. 16, 2020, 7:01 a.m. UTC | #1
On Wed, 16 Sep 2020 11:43:31 +0530
Ani Sinha <ani@anisinha.ca> wrote:

> This change adds a new unit test for the global flag

> 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci

> bridges in i440fx. The flag can be used to turn off acpi based hotplug support

> for all pci bridges.

> 

> Signed-off-by: Ani Sinha <ani@anisinha.ca>

> ---

>  tests/qtest/bios-tables-test.c | 15 +++++++++++++++

>  1 file changed, 15 insertions(+)

> 

> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c

> index d8c7d57557..7632cfe1be 100644

> --- a/tests/qtest/bios-tables-test.c

> +++ b/tests/qtest/bios-tables-test.c

> @@ -754,6 +754,20 @@ static void test_acpi_piix4_root_hotplug(void)

>      free_test_data(&data);

>  }

>  

> +static void test_acpi_piix4_bridge_hotplug(void)

s/bridge_hotplug/no_bridge_hotplug/

> +{

> +    test_data data;

> +

> +    memset(&data, 0, sizeof(data));

> +    data.machine = MACHINE_PC;

> +    data.variant = ".hpbridge";

> +    data.required_struct_types = base_required_struct_types;

> +    data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);

> +    test_acpi_one("-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off "

> +                  "-device pci-bridge,chassis_nr=1", &data);

> +    free_test_data(&data);

> +}

> +

>  static void test_acpi_q35_tcg(void)

>  {

>      test_data data;

> @@ -1159,6 +1173,7 @@ int main(int argc, char *argv[])

>          qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);

>          qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);

>          qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);

> +        qtest_add_func("acpi/piix4/brhotplug", test_acpi_piix4_bridge_hotplug);

s/brhotplug/no_bridge_hotplug/
or add bridge group and do
s:brhotplug:bridge/hotplug/off:
and move other bridge tests under it

>          qtest_add_func("acpi/q35", test_acpi_q35_tcg);

>          qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);

>          qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
diff mbox series

Patch

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index d8c7d57557..7632cfe1be 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -754,6 +754,20 @@  static void test_acpi_piix4_root_hotplug(void)
     free_test_data(&data);
 }
 
+static void test_acpi_piix4_bridge_hotplug(void)
+{
+    test_data data;
+
+    memset(&data, 0, sizeof(data));
+    data.machine = MACHINE_PC;
+    data.variant = ".hpbridge";
+    data.required_struct_types = base_required_struct_types;
+    data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
+    test_acpi_one("-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off "
+                  "-device pci-bridge,chassis_nr=1", &data);
+    free_test_data(&data);
+}
+
 static void test_acpi_q35_tcg(void)
 {
     test_data data;
@@ -1159,6 +1173,7 @@  int main(int argc, char *argv[])
         qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
         qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
         qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);
+        qtest_add_func("acpi/piix4/brhotplug", test_acpi_piix4_bridge_hotplug);
         qtest_add_func("acpi/q35", test_acpi_q35_tcg);
         qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
         qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);