| Message ID | 20200905213049.761949-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/mips/malta: Fix FPGA I/O region size | expand |
ping? On 9/5/20 11:30 PM, Philippe Mathieu-Daudé wrote: > The FPGA present on the CoreCard has an I/O region 1MiB wide. > > Refs: > - Atlas User’s Manual (Document Number: MD00005) > - Malta User’s Manual (Document Number: MD00048) > > Fixes: ea85df72b60 ("mips_malta: convert to memory API") > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/mips/malta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/mips/malta.c b/hw/mips/malta.c > index a59e20c81c5..6a19be0a5dc 100644 > --- a/hw/mips/malta.c > +++ b/hw/mips/malta.c > @@ -574,7 +574,7 @@ static MaltaFPGAState *malta_fpga_init(MemoryRegion *address_space, > memory_region_init_alias(&s->iomem_lo, NULL, "malta-fpga", > &s->iomem, 0, 0x900); > memory_region_init_alias(&s->iomem_hi, NULL, "malta-fpga", > - &s->iomem, 0xa00, 0x10000 - 0xa00); > + &s->iomem, 0xa00, 0x100000 - 0xa00); > > memory_region_add_subregion(address_space, base, &s->iomem_lo); > memory_region_add_subregion(address_space, base + 0xa00, &s->iomem_hi); >
On 9/5/20 11:30 PM, Philippe Mathieu-Daudé wrote: > The FPGA present on the CoreCard has an I/O region 1MiB wide. > > Refs: > - Atlas User’s Manual (Document Number: MD00005) > - Malta User’s Manual (Document Number: MD00048) > > Fixes: ea85df72b60 ("mips_malta: convert to memory API") > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/mips/malta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my mips-hw-next tree.
diff --git a/hw/mips/malta.c b/hw/mips/malta.c index a59e20c81c5..6a19be0a5dc 100644 --- a/hw/mips/malta.c +++ b/hw/mips/malta.c @@ -574,7 +574,7 @@ static MaltaFPGAState *malta_fpga_init(MemoryRegion *address_space, memory_region_init_alias(&s->iomem_lo, NULL, "malta-fpga", &s->iomem, 0, 0x900); memory_region_init_alias(&s->iomem_hi, NULL, "malta-fpga", - &s->iomem, 0xa00, 0x10000 - 0xa00); + &s->iomem, 0xa00, 0x100000 - 0xa00); memory_region_add_subregion(address_space, base, &s->iomem_lo); memory_region_add_subregion(address_space, base + 0xa00, &s->iomem_hi);
The FPGA present on the CoreCard has an I/O region 1MiB wide. Refs: - Atlas User’s Manual (Document Number: MD00005) - Malta User’s Manual (Document Number: MD00048) Fixes: ea85df72b60 ("mips_malta: convert to memory API") Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/mips/malta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)