[1/1] net: tso: Export symbols for modular build

Message ID 1401096166-5409-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat May 26, 2014, 9:22 a.m.
Export the symbols to fix the below errors when built as modules:
ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_start" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "tso_start" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 net/core/tso.c |    5 +++++
 1 file changed, 5 insertions(+)

Comments

Ezequiel Garcia May 26, 2014, 11:15 a.m. | #1
On 26 May 02:52 PM, Sachin Kamat wrote:
> Export the symbols to fix the below errors when built as modules:
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Thanks for the fix,
David Miller May 30, 2014, 10:52 p.m. | #2
From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon, 26 May 2014 14:52:46 +0530

> Export the symbols to fix the below errors when built as modules:
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
> ERROR: "tso_build_data" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_build_hdr" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_start" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> ERROR: "tso_count_descs" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined!
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/core/tso.c b/net/core/tso.c
index 097821dd3a8c..8c3203c585b0 100644
--- a/net/core/tso.c
+++ b/net/core/tso.c
@@ -1,3 +1,4 @@ 
+#include <linux/export.h>
 #include <net/ip.h>
 #include <net/tso.h>
 
@@ -7,6 +8,7 @@  int tso_count_descs(struct sk_buff *skb)
 	/* The Marvell Way */
 	return skb_shinfo(skb)->gso_segs * 2 + skb_shinfo(skb)->nr_frags;
 }
+EXPORT_SYMBOL(tso_count_descs);
 
 void tso_build_hdr(struct sk_buff *skb, char *hdr, struct tso_t *tso,
 		   int size, bool is_last)
@@ -31,6 +33,7 @@  void tso_build_hdr(struct sk_buff *skb, char *hdr, struct tso_t *tso,
 		tcph->rst = 0;
 	}
 }
+EXPORT_SYMBOL(tso_build_hdr);
 
 void tso_build_data(struct sk_buff *skb, struct tso_t *tso, int size)
 {
@@ -48,6 +51,7 @@  void tso_build_data(struct sk_buff *skb, struct tso_t *tso, int size)
 		tso->next_frag_idx++;
 	}
 }
+EXPORT_SYMBOL(tso_build_data);
 
 void tso_start(struct sk_buff *skb, struct tso_t *tso)
 {
@@ -70,3 +74,4 @@  void tso_start(struct sk_buff *skb, struct tso_t *tso)
 		tso->next_frag_idx++;
 	}
 }
+EXPORT_SYMBOL(tso_start);