diff mbox

[1/1] ARM: vt8500: Staticize local symbols

Message ID 1401191863-9404-1-git-send-email-sachin.kamat@linaro.org
State Superseded
Headers show

Commit Message

Sachin Kamat May 27, 2014, 11:57 a.m. UTC
Variables local to this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/mach-vt8500/vt8500.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Arnd Bergmann May 27, 2014, 12:05 p.m. UTC | #1
On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
> Variables local to this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/mach-vt8500/vt8500.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Arnd Bergmann <arnd@arndb.de>

Looks good to me, but you forgot to take the maintainer on Cc.

How should we handle this patch? I guess this is the only one
for vt8500 in 3.16, so I can pick it up directly with Tony's
Ack.

> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> index 4a73464cb11b..2da7be31e7e2 100644
> --- a/arch/arm/mach-vt8500/vt8500.c
> +++ b/arch/arm/mach-vt8500/vt8500.c
> @@ -44,7 +44,7 @@
>  
>  static void __iomem *pmc_base;
>  
> -void vt8500_restart(enum reboot_mode mode, const char *cmd)
> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
>  {
>  	if (pmc_base)
>  		writel(1, pmc_base + VT8500_PMSR_REG);
> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
>  	},
>  };
>  
> -void __init vt8500_map_io(void)
> +static void __init vt8500_map_io(void)
>  {
>  	iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
>  }
> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
>  	asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>  }
>  
> -void __init vt8500_init(void)
> +static void __init vt8500_init(void)
>  {
>  	struct device_node *np;
>  #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>
Tony Prisk May 29, 2014, 8:44 p.m. UTC | #2
On 28/05/14 00:05, Arnd Bergmann wrote:
> On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
>> Variables local to this file are made static.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>   arch/arm/mach-vt8500/vt8500.c |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Looks good to me, but you forgot to take the maintainer on Cc.
>
> How should we handle this patch? I guess this is the only one
> for vt8500 in 3.16, so I can pick it up directly with Tony's
> Ack.
>
>> diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
>> index 4a73464cb11b..2da7be31e7e2 100644
>> --- a/arch/arm/mach-vt8500/vt8500.c
>> +++ b/arch/arm/mach-vt8500/vt8500.c
>> @@ -44,7 +44,7 @@
>>   
>>   static void __iomem *pmc_base;
>>   
>> -void vt8500_restart(enum reboot_mode mode, const char *cmd)
>> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
>>   {
>>   	if (pmc_base)
>>   		writel(1, pmc_base + VT8500_PMSR_REG);
>> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
>>   	},
>>   };
>>   
>> -void __init vt8500_map_io(void)
>> +static void __init vt8500_map_io(void)
>>   {
>>   	iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
>>   }
>> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
>>   	asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>>   }
>>   
>> -void __init vt8500_init(void)
>> +static void __init vt8500_init(void)
>>   {
>>   	struct device_node *np;
>>   #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>>
Acked-by: Tony Prisk <linux@prisktech.co.nz>

Can you pick this up please Arnd? Doesn't look like there will be 
anything else for 3.16

Regards
Tony P
Sachin Kamat May 30, 2014, 6:19 a.m. UTC | #3
On 30 May 2014 02:14, Tony Prisk <linux@prisktech.co.nz> wrote:
>
> On 28/05/14 00:05, Arnd Bergmann wrote:
>>
>> On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
>>>
>>> Variables local to this file are made static.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>>   arch/arm/mach-vt8500/vt8500.c |    6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Looks good to me, but you forgot to take the maintainer on Cc.
>>
>> How should we handle this patch? I guess this is the only one
>> for vt8500 in 3.16, so I can pick it up directly with Tony's
>> Ack.
>>
>>> diff --git a/arch/arm/mach-vt8500/vt8500.c
>>> b/arch/arm/mach-vt8500/vt8500.c
>>> index 4a73464cb11b..2da7be31e7e2 100644
>>> --- a/arch/arm/mach-vt8500/vt8500.c
>>> +++ b/arch/arm/mach-vt8500/vt8500.c
>>> @@ -44,7 +44,7 @@
>>>     static void __iomem *pmc_base;
>>>   -void vt8500_restart(enum reboot_mode mode, const char *cmd)
>>> +static void vt8500_restart(enum reboot_mode mode, const char *cmd)
>>>   {
>>>         if (pmc_base)
>>>                 writel(1, pmc_base + VT8500_PMSR_REG);
>>> @@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
>>>         },
>>>   };
>>>   -void __init vt8500_map_io(void)
>>> +static void __init vt8500_map_io(void)
>>>   {
>>>         iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
>>>   }
>>> @@ -72,7 +72,7 @@ static void vt8500_power_off(void)
>>>         asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>>>   }
>>>   -void __init vt8500_init(void)
>>> +static void __init vt8500_init(void)
>>>   {
>>>         struct device_node *np;
>>>   #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
>>>
> Acked-by: Tony Prisk <linux@prisktech.co.nz>

Thanks Tony.

> Can you pick this up please Arnd? Doesn't look like there will be anything
> else for 3.16

Arnd,

I have a few more similar patches for other platforms (mvebu, sti, spear).
Can I send them as well along with the accumulated acks for you to apply?

---
With warm regards,
Sachin
Arnd Bergmann May 30, 2014, 2:53 p.m. UTC | #4
On Friday 30 May 2014 11:49:02 Sachin Kamat wrote:
> 
> I have a few more similar patches for other platforms (mvebu, sti, spear).
> Can I send them as well along with the accumulated acks for you to apply?

Yes, that's fine. If you can, please send a pull request with the lot
to arm@kernel.org, with the maintainers and linux-arm-kernel on Cc.

	Arnd
Sachin Kamat May 30, 2014, 5:03 p.m. UTC | #5
On 30 May 2014 20:23, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 30 May 2014 11:49:02 Sachin Kamat wrote:
>>
>> I have a few more similar patches for other platforms (mvebu, sti, spear).
>> Can I send them as well along with the accumulated acks for you to apply?
>
> Yes, that's fine. If you can, please send a pull request with the lot
> to arm@kernel.org, with the maintainers and linux-arm-kernel on Cc.

Actually, I happened to post all the 8 patches to linux-arm-kernel
with the respective
maintainers and you in Cc before leaving for the weekend (The first
patch in the series
being "[PATCH Resend 1/8] ARM: sti: Staticize local variables").
Please see if you can
pick them up. Else I will send you a pull request on Monday.
diff mbox

Patch

diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 4a73464cb11b..2da7be31e7e2 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -44,7 +44,7 @@ 
 
 static void __iomem *pmc_base;
 
-void vt8500_restart(enum reboot_mode mode, const char *cmd)
+static void vt8500_restart(enum reboot_mode mode, const char *cmd)
 {
 	if (pmc_base)
 		writel(1, pmc_base + VT8500_PMSR_REG);
@@ -60,7 +60,7 @@  static struct map_desc vt8500_io_desc[] __initdata = {
 	},
 };
 
-void __init vt8500_map_io(void)
+static void __init vt8500_map_io(void)
 {
 	iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
 }
@@ -72,7 +72,7 @@  static void vt8500_power_off(void)
 	asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
 }
 
-void __init vt8500_init(void)
+static void __init vt8500_init(void)
 {
 	struct device_node *np;
 #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)