diff mbox

[v2,Resend,1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

Message ID 1401250382-24046-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Commit 35e75645f16c86918f26df1bfc2c24ad8ebb5a17
Headers show

Commit Message

Sachin Kamat May 28, 2014, 4:13 a.m. UTC
Almost all Exynos-series of SoCs that run in secure mode don't need
additional offset for every CPU, with Exynos4412 being the only
exception.

Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).

While at it, fix the coding style (space around *).

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Andreas Färber May 30, 2014, 6:19 p.m. UTC | #1
Am 28.05.2014 06:13, schrieb Sachin Kamat:
> Almost all Exynos-series of SoCs that run in secure mode don't need
> additional offset for every CPU, with Exynos4412 being the only
> exception.
> 
> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
> 
> While at it, fix the coding style (space around *).
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
applying the 5410 patches...

Tested-by: Andreas Färber <afaerber@suse.de>

Regards,
Andreas
Kukjin Kim May 30, 2014, 6:42 p.m. UTC | #2
On 05/31/14 03:19, Andreas Färber wrote:
> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>> Almost all Exynos-series of SoCs that run in secure mode don't need
>> additional offset for every CPU, with Exynos4412 being the only
>> exception.
>>
>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>
>> While at it, fix the coding style (space around *).
>>
>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>> ---
>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
> applying the 5410 patches...
>
> Tested-by: Andreas Färber<afaerber@suse.de>
>
Andreas, thanks for your test :-)

Sachin, How about exynos4210, 5250, 5260 and 5440?...
I need to check again, honestly I don't remember all of Exynos SoCs' 
different things ;-) Then will apply into fixes for 3.16.

Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Figa May 30, 2014, 6:47 p.m. UTC | #3
On 30.05.2014 20:42, Kukjin Kim wrote:
> On 05/31/14 03:19, Andreas Färber wrote:
>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>> additional offset for every CPU, with Exynos4412 being the only
>>> exception.
>>>
>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>
>>> While at it, fix the coding style (space around *).
>>>
>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>>> ---
>>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>> applying the 5410 patches...
>>
>> Tested-by: Andreas Färber<afaerber@suse.de>
>>
> Andreas, thanks for your test :-)
> 
> Sachin, How about exynos4210, 5250, 5260 and 5440?...
> I need to check again, honestly I don't remember all of Exynos SoCs'
> different things ;-) Then will apply into fixes for 3.16.

Exynos4210 doesn't use secure firmware, at least on any board supported
in mainline. Not sure about those Exynos5 models, but the only boards
supported in mainline with firmware node in DT are based on Exynos4412
or Exynos5410.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sachin Kamat June 13, 2014, 4:25 p.m. UTC | #4
Kukjin,

On Sat, May 31, 2014 at 12:12 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 05/31/14 03:19, Andreas Färber wrote:
>>
>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>>
>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>> additional offset for every CPU, with Exynos4412 being the only
>>> exception.
>>>
>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>
>>> While at it, fix the coding style (space around *).
>>>
>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>>> ---
>>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>>
>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>> applying the 5410 patches...
>>
>> Tested-by: Andreas Färber<afaerber@suse.de>
>>
> Andreas, thanks for your test :-)
>
> Sachin, How about exynos4210, 5250, 5260 and 5440?...
> I need to check again, honestly I don't remember all of Exynos SoCs'
> different things ;-) Then will apply into fixes for 3.16.

ping..

 --
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sachin Kamat June 23, 2014, 4:33 a.m. UTC | #5
On Fri, May 30, 2014 at 11:49 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>> Almost all Exynos-series of SoCs that run in secure mode don't need
>> additional offset for every CPU, with Exynos4412 being the only
>> exception.
>>
>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>
>> While at it, fix the coding style (space around *).
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
> applying the 5410 patches...
>
> Tested-by: Andreas Färber <afaerber@suse.de>
>

Kukjin, this patch is required to bring up 4 A15 cores on some 5410
and 5420 based
boards. Can you please queue this up for the upcoming rc as fixes?
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tushar Behera June 25, 2014, 10:47 a.m. UTC | #6
On 05/31/2014 12:17 AM, Tomasz Figa wrote:
> On 30.05.2014 20:42, Kukjin Kim wrote:
>> On 05/31/14 03:19, Andreas Färber wrote:
>>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>>> additional offset for every CPU, with Exynos4412 being the only
>>>> exception.
>>>>
>>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>>
>>>> While at it, fix the coding style (space around *).
>>>>
>>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>>>> ---
>>>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>>> applying the 5410 patches...
>>>
>>> Tested-by: Andreas Färber<afaerber@suse.de>
>>>
>> Andreas, thanks for your test :-)
>>
>> Sachin, How about exynos4210, 5250, 5260 and 5440?...
>> I need to check again, honestly I don't remember all of Exynos SoCs'
>> different things ;-) Then will apply into fixes for 3.16.
> 
> Exynos4210 doesn't use secure firmware, at least on any board supported
> in mainline. Not sure about those Exynos5 models, but the only boards
> supported in mainline with firmware node in DT are based on Exynos4412
> or Exynos5410.
> 
> Best regards,
> Tomasz
> 

Kukjin,

Would you please pick this patch as a fix for 3.16?
Kukjin Kim June 25, 2014, 11:43 a.m. UTC | #7
Sachin Kamat wrote:
> 
> On Fri, May 30, 2014 at 11:49 PM, Andreas Färber <afaerber@suse.de> wrote:
> > Am 28.05.2014 06:13, schrieb Sachin Kamat:
> >> Almost all Exynos-series of SoCs that run in secure mode don't need
> >> additional offset for every CPU, with Exynos4412 being the only
> >> exception.
> >>
> >> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
> >>
> >> While at it, fix the coding style (space around *).
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >> ---
> >>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
> >>  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
> > applying the 5410 patches...
> >
> > Tested-by: Andreas Färber <afaerber@suse.de>
> >
> 
> Kukjin, this patch is required to bring up 4 A15 cores on some 5410
> and 5420 based
> boards. Can you please queue this up for the upcoming rc as fixes?

Sure, I will take this into fixes.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andreas Färber June 25, 2014, 11:54 a.m. UTC | #8
Am 25.06.2014 13:43, schrieb Kukjin Kim:
> Sachin Kamat wrote:
>>
>> On Fri, May 30, 2014 at 11:49 PM, Andreas Färber <afaerber@suse.de> wrote:
>>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>>> additional offset for every CPU, with Exynos4412 being the only
>>>> exception.
>>>>
>>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>>
>>>> While at it, fix the coding style (space around *).
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>> ---
>>>>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>>> applying the 5410 patches...
>>>
>>> Tested-by: Andreas Färber <afaerber@suse.de>

FWIW meanwhile I also successfully tested it on 5420 based Arndale Octa.

I can also check on 5250 based Spring, now that it's working, if that
helps build confidence in the patch.

Cheers,
Andreas

>> Kukjin, this patch is required to bring up 4 A15 cores on some 5410
>> and 5420 based
>> boards. Can you please queue this up for the upcoming rc as fixes?
> 
> Sure, I will take this into fixes.
> 
> Thanks,
> Kukjin
Sachin Kamat July 5, 2014, 2:53 p.m. UTC | #9
On Wed, Jun 25, 2014 at 5:13 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> On Fri, May 30, 2014 at 11:49 PM, Andreas Färber <afaerber@suse.de> wrote:
>> > Am 28.05.2014 06:13, schrieb Sachin Kamat:
>> >> Almost all Exynos-series of SoCs that run in secure mode don't need
>> >> additional offset for every CPU, with Exynos4412 being the only
>> >> exception.
>> >>
>> >> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>> >>
>> >> While at it, fix the coding style (space around *).
>> >>
>> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> >> ---
>> >>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>> >>  1 file changed, 7 insertions(+), 2 deletions(-)
>> >
>> > Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>> > applying the 5410 patches...
>> >
>> > Tested-by: Andreas Färber <afaerber@suse.de>
>> >
>>
>> Kukjin, this patch is required to bring up 4 A15 cores on some 5410
>> and 5420 based
>> boards. Can you please queue this up for the upcoming rc as fixes?
>
> Sure, I will take this into fixes.

Kukjin,

I don't see this patch in your fixes-2 branch yet.


>
> Thanks,
> Kukjin
>

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index eb91d2350f8c..e8797bb78871 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -57,8 +57,13 @@  static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
 
 	boot_reg = sysram_ns_base_addr + 0x1c;
 
-	if (!soc_is_exynos4212() && !soc_is_exynos3250())
-		boot_reg += 4*cpu;
+	/*
+	 * Almost all Exynos-series of SoCs that run in secure mode don't need
+	 * additional offset for every CPU, with Exynos4412 being the only
+	 * exception.
+	 */
+	if (soc_is_exynos4412())
+		boot_reg += 4 * cpu;
 
 	__raw_writel(boot_addr, boot_reg);
 	return 0;