diff mbox

[1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

Message ID 1401345049-14779-1-git-send-email-sachin.kamat@linaro.org
State Superseded
Headers show

Commit Message

Sachin Kamat May 29, 2014, 6:30 a.m. UTC
PTR_ERR_OR_ZERO simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>
---
 drivers/phy/phy-exynos-dp-video.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Jingoo Han June 2, 2014, 2:26 a.m. UTC | #1
On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
> 
> PTR_ERR_OR_ZERO simplifies the code.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>

Acked-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/phy/phy-exynos-dp-video.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
> index 0786fef842e7..098f822a2fa4 100644
> --- a/drivers/phy/phy-exynos-dp-video.c
> +++ b/drivers/phy/phy-exynos-dp-video.c
> @@ -9,6 +9,7 @@
>   * published by the Free Software Foundation.
>   */
> 
> +#include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>  	phy_set_drvdata(phy, state);
> 
>  	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> -	if (IS_ERR(phy_provider))
> -		return PTR_ERR(phy_provider);
> 
> -	return 0;
> +	return PTR_ERR_OR_ZERO(phy_provider);
>  }
> 
>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
> --
> 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Sachin Kamat June 12, 2014, 9:49 a.m. UTC | #2
Hi Kishon,

On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>
>> PTR_ERR_OR_ZERO simplifies the code.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
> Best regards,
> Jingoo Han
>
>> ---
>>  drivers/phy/phy-exynos-dp-video.c |    5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>> index 0786fef842e7..098f822a2fa4 100644
>> --- a/drivers/phy/phy-exynos-dp-video.c
>> +++ b/drivers/phy/phy-exynos-dp-video.c
>> @@ -9,6 +9,7 @@
>>   * published by the Free Software Foundation.
>>   */
>>
>> +#include <linux/err.h>
>>  #include <linux/io.h>
>>  #include <linux/kernel.h>
>>  #include <linux/module.h>
>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>       phy_set_drvdata(phy, state);
>>
>>       phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>> -     if (IS_ERR(phy_provider))
>> -             return PTR_ERR(phy_provider);
>>
>> -     return 0;
>> +     return PTR_ERR_OR_ZERO(phy_provider);
>>  }
>>
>>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>> --
>> 1.7.9.5
>
>

ping on this series.
Kishon Vijay Abraham I June 12, 2014, 9:57 a.m. UTC | #3
On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
> Hi Kishon,
> 
> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>
>>> PTR_ERR_OR_ZERO simplifies the code.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> Cc: Jingoo Han <jg1.han@samsung.com>
>>
>> Acked-by: Jingoo Han <jg1.han@samsung.com>
>>
>> Best regards,
>> Jingoo Han
>>
>>> ---
>>>  drivers/phy/phy-exynos-dp-video.c |    5 ++---
>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>>> index 0786fef842e7..098f822a2fa4 100644
>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>> @@ -9,6 +9,7 @@
>>>   * published by the Free Software Foundation.
>>>   */
>>>
>>> +#include <linux/err.h>
>>>  #include <linux/io.h>
>>>  #include <linux/kernel.h>
>>>  #include <linux/module.h>
>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>>       phy_set_drvdata(phy, state);
>>>
>>>       phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>>> -     if (IS_ERR(phy_provider))
>>> -             return PTR_ERR(phy_provider);
>>>
>>> -     return 0;
>>> +     return PTR_ERR_OR_ZERO(phy_provider);
>>>  }
>>>
>>>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>> --
>>> 1.7.9.5
>>
>>
> 
> ping on this series.

I'll queue to -next once -rc1 is tagged.

-Kishon
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Sachin Kamat June 12, 2014, 9:59 a.m. UTC | #4
On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> Cc: Jingoo Han <jg1.han@samsung.com>
>>>
>>> Acked-by: Jingoo Han <jg1.han@samsung.com>
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>>  drivers/phy/phy-exynos-dp-video.c |    5 ++---
>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>>   * published by the Free Software Foundation.
>>>>   */
>>>>
>>>> +#include <linux/err.h>
>>>>  #include <linux/io.h>
>>>>  #include <linux/kernel.h>
>>>>  #include <linux/module.h>
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>>>       phy_set_drvdata(phy, state);
>>>>
>>>>       phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>>>> -     if (IS_ERR(phy_provider))
>>>> -             return PTR_ERR(phy_provider);
>>>>
>>>> -     return 0;
>>>> +     return PTR_ERR_OR_ZERO(phy_provider);
>>>>  }
>>>>
>>>>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.

Thanks Kishon.
Sachin Kamat July 2, 2014, 8:44 a.m. UTC | #5
On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> Cc: Jingoo Han <jg1.han@samsung.com>
>>>
>>> Acked-by: Jingoo Han <jg1.han@samsung.com>
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>>  drivers/phy/phy-exynos-dp-video.c |    5 ++---
>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>>   * published by the Free Software Foundation.
>>>>   */
>>>>
>>>> +#include <linux/err.h>
>>>>  #include <linux/io.h>
>>>>  #include <linux/kernel.h>
>>>>  #include <linux/module.h>
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>>>       phy_set_drvdata(phy, state);
>>>>
>>>>       phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>>>> -     if (IS_ERR(phy_provider))
>>>> -             return PTR_ERR(phy_provider);
>>>>
>>>> -     return 0;
>>>> +     return PTR_ERR_OR_ZERO(phy_provider);
>>>>  }
>>>>
>>>>  static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.

Gentle ping..
diff mbox

Patch

diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
index 0786fef842e7..098f822a2fa4 100644
--- a/drivers/phy/phy-exynos-dp-video.c
+++ b/drivers/phy/phy-exynos-dp-video.c
@@ -9,6 +9,7 @@ 
  * published by the Free Software Foundation.
  */
 
+#include <linux/err.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
@@ -84,10 +85,8 @@  static int exynos_dp_video_phy_probe(struct platform_device *pdev)
 	phy_set_drvdata(phy, state);
 
 	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-	if (IS_ERR(phy_provider))
-		return PTR_ERR(phy_provider);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(phy_provider);
 }
 
 static const struct of_device_id exynos_dp_video_phy_of_match[] = {