diff mbox series

[3/4] arm64: dts: ti: k3-am65: mark dss as dma-coherent

Message ID 20201027104132.105485-4-tomi.valkeinen@ti.com
State Superseded
Headers show
Series [1/4] arm64: dts: ti: k3-j721e-main: add DP & DP PHY | expand

Commit Message

Tomi Valkeinen Oct. 27, 2020, 10:41 a.m. UTC
DSS is IO coherent on AM65, so we can mark it as such with
'dma-coherent' property in the DT file.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Nishanth Menon Oct. 27, 2020, 12:34 p.m. UTC | #1
On 12:41-20201027, Tomi Valkeinen wrote:
> DSS is IO coherent on AM65, so we can mark it as such with

> 'dma-coherent' property in the DT file.

> 

> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> ---

>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

> index 533525229a8d..a0b4a421026f 100644

> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

> @@ -867,6 +867,8 @@ dss: dss@04a00000 {

>  

>  		status = "disabled";

>  

> +		dma-coherent;

> +

>  		dss_ports: ports {

>  			#address-cells = <1>;

>  			#size-cells = <0>;

> -- 

> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.

> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

> 


Does it need to be part of this series?

I'd appreciate an additional reviewed-by from folks..
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Tomi Valkeinen Oct. 27, 2020, 2:45 p.m. UTC | #2
On 27/10/2020 14:34, Nishanth Menon wrote:
> On 12:41-20201027, Tomi Valkeinen wrote:

>> DSS is IO coherent on AM65, so we can mark it as such with

>> 'dma-coherent' property in the DT file.

>>

>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

>> ---

>>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++

>>  1 file changed, 2 insertions(+)

>>

>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

>> index 533525229a8d..a0b4a421026f 100644

>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

>> @@ -867,6 +867,8 @@ dss: dss@04a00000 {

>>  

>>  		status = "disabled";

>>  

>> +		dma-coherent;

>> +

>>  		dss_ports: ports {

>>  			#address-cells = <1>;

>>  			#size-cells = <0>;

>> -- 

>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.

>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

>>

> 

> Does it need to be part of this series?


No. The two DP patches should go together, but the am6 ones can be applied independently.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Nishanth Menon Oct. 27, 2020, 3:14 p.m. UTC | #3
On 16:45-20201027, Tomi Valkeinen wrote:
> On 27/10/2020 14:34, Nishanth Menon wrote:

> > On 12:41-20201027, Tomi Valkeinen wrote:

> >> DSS is IO coherent on AM65, so we can mark it as such with

> >> 'dma-coherent' property in the DT file.

> >>

> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> >> ---

> >>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++

> >>  1 file changed, 2 insertions(+)

> >>

> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

> >> index 533525229a8d..a0b4a421026f 100644

> >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

> >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi

> >> @@ -867,6 +867,8 @@ dss: dss@04a00000 {

> >>  

> >>  		status = "disabled";

> >>  

> >> +		dma-coherent;

> >> +

> >>  		dss_ports: ports {

> >>  			#address-cells = <1>;

> >>  			#size-cells = <0>;

> >> -- 

> >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.

> >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

> >>

> > 

> > Does it need to be part of this series?

> 

> No. The two DP patches should go together, but the am6 ones can be applied independently.



Please split accordingly.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 533525229a8d..a0b4a421026f 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -867,6 +867,8 @@  dss: dss@04a00000 {
 
 		status = "disabled";
 
+		dma-coherent;
+
 		dss_ports: ports {
 			#address-cells = <1>;
 			#size-cells = <0>;