[v2,1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles

Message ID 20201029162133.81016-1-krzk@kernel.org
State New
Headers show
Series
  • [v2,1/2] dt-bindings: watchdog: fsl-imx: document NXP compatibles
Related show

Commit Message

Krzysztof Kozlowski Oct. 29, 2020, 4:21 p.m.
Document all ARMv5, ARMv6, ARMv7 and ARMv8 NXP (i.MX, Layerscape)
compatibles used in DTSes (even though driver binds only to
fsl,imx21-wdt) to fix dtbs_check warnings like:

  arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:
    ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>

---

Changes since v1:
1. Add also Layerscape,
2. Add Rob's review tag.
---
 .../bindings/watchdog/fsl-imx-wdt.yaml           | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Shawn Guo Oct. 30, 2020, 12:38 a.m. | #1
On Thu, Oct 29, 2020 at 05:21:32PM +0100, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6, ARMv7 and ARMv8 NXP (i.MX, Layerscape)

> compatibles used in DTSes (even though driver binds only to

> fsl,imx21-wdt) to fix dtbs_check warnings like:

> 

>   arch/arm/boot/dts/imx53-qsb.dt.yaml: gpio@53fe0000: compatible:

>     ['fsl,imx53-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas

> 

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> Reviewed-by: Rob Herring <robh@kernel.org>


Applied, thanks.
Shawn Guo Oct. 30, 2020, 12:40 a.m. | #2
On Thu, Oct 29, 2020 at 05:21:33PM +0100, Krzysztof Kozlowski wrote:
> The dtschema expects watchdog device node name to be "watchdog":
> 
>   arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dt.yaml: wdog@2ad0000:
>     $nodename:0: 'wdog@2ad0000' does not match '^watchdog(@.*|-[0-9a-f])?$'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

s/ARM/arm64 in subject.

I fixed it up and applied the patch.

Shawn

> 
> ---
> 
> Changes since v1:
> 1. New patch
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 991b4e33486e..fb7695515be1 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -18,10 +18,26 @@  properties:
       - const: fsl,imx21-wdt
       - items:
           - enum:
+              - fsl,imx25-wdt
+              - fsl,imx27-wdt
+              - fsl,imx31-wdt
+              - fsl,imx35-wdt
+              - fsl,imx50-wdt
+              - fsl,imx51-wdt
+              - fsl,imx53-wdt
+              - fsl,imx6q-wdt
+              - fsl,imx6sl-wdt
+              - fsl,imx6sll-wdt
+              - fsl,imx6sx-wdt
+              - fsl,imx6ul-wdt
+              - fsl,imx7d-wdt
               - fsl,imx8mm-wdt
               - fsl,imx8mn-wdt
               - fsl,imx8mp-wdt
               - fsl,imx8mq-wdt
+              - fsl,ls1012a-wdt
+              - fsl,ls1043a-wdt
+              - fsl,vf610-wdt
           - const: fsl,imx21-wdt
 
   reg: