From patchwork Mon Jun 2 07:00:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 31246 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f69.google.com (mail-yh0-f69.google.com [209.85.213.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D6F88203C2 for ; Mon, 2 Jun 2014 07:00:46 +0000 (UTC) Received: by mail-yh0-f69.google.com with SMTP id i57sf23821553yha.8 for ; Mon, 02 Jun 2014 00:00:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=qh++Ea2CEqePY8DcG2rP5lmtFHVuzAo8MlzmpOgs0ZQ=; b=Y/loVAxYA1ljZ9Ow8jdJ1DyfURYK5svcgoCqSBYmuO7TRhd9Eib7CjZdtdaGYiKMj8 uIbXcVf+YrLx6aiWnjHqIQfCPNBk1o9ewGXKsdNQgdF/liSiahGS0zBU90jzW8D8sOEe TqDZ1ZHmmkLxnENesroge3ozwliAWpJkOzWoSZv/rw0ixlTgDm/Rt3P7H2OJYRsC4ciM SLbX705lljulgGFToljy46w95y8XyHvxpvst7C0eGxquPJx1//d1GC7UiD47WZrmrcdg e6hfJwX+J0LVVbuXFlZ/TbdZQMvc6S+5Ap1GfGF8NI7r/iORMF5XtIC5A8m/NCpXCiIr 3dAA== X-Gm-Message-State: ALoCoQk6tNivxyZdfsDrPvdBD2u2YGaBroeRMjzRVf3edXYkELO2kbqL9sXc6otFaVgkZc/XdlGB X-Received: by 10.236.110.68 with SMTP id t44mr10727853yhg.31.1401692446608; Mon, 02 Jun 2014 00:00:46 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.34.196 with SMTP id l62ls1529638qgl.35.gmail; Mon, 02 Jun 2014 00:00:46 -0700 (PDT) X-Received: by 10.58.188.37 with SMTP id fx5mr28991472vec.17.1401692446515; Mon, 02 Jun 2014 00:00:46 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id cd10si7479349vcb.54.2014.06.02.00.00.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 00:00:46 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.179 as permitted sender) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id oy12so4757190veb.10 for ; Mon, 02 Jun 2014 00:00:46 -0700 (PDT) X-Received: by 10.52.13.41 with SMTP id e9mr24032763vdc.21.1401692446420; Mon, 02 Jun 2014 00:00:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp76229vcb; Mon, 2 Jun 2014 00:00:46 -0700 (PDT) X-Received: by 10.68.178.131 with SMTP id cy3mr38833709pbc.146.1401692445592; Mon, 02 Jun 2014 00:00:45 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hq3si14992848pad.87.2014.06.02.00.00.45; Mon, 02 Jun 2014 00:00:45 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752482AbaFBHAo (ORCPT + 13 others); Mon, 2 Jun 2014 03:00:44 -0400 Received: from mail-qa0-f51.google.com ([209.85.216.51]:59972 "EHLO mail-qa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbaFBHAn (ORCPT ); Mon, 2 Jun 2014 03:00:43 -0400 Received: by mail-qa0-f51.google.com with SMTP id w8so2131987qac.38 for ; Mon, 02 Jun 2014 00:00:42 -0700 (PDT) X-Received: by 10.224.7.6 with SMTP id b6mr46995120qab.45.1401692442285; Mon, 02 Jun 2014 00:00:42 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id o14sm7841085qga.25.2014.06.02.00.00.37 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Jun 2014 00:00:41 -0700 (PDT) From: Viresh Kumar To: rjw@rjwysocki.net Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arvind.chauhan@arm.com, inderpal.s@samsung.com, nm@ti.com, chander.kashyap@linaro.org, pavel@ucw.cz, len.brown@intel.com, sudeep.holla@arm.com, Viresh Kumar Subject: [PATCH V5 3/8] opp: Enhance debug messages in of_init_opp_table() Date: Mon, 2 Jun 2014 12:30:33 +0530 Message-Id: <7373788d1dd01bd99cd22fbfaf94327d42e58935.1401691974.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: <2a9d8e2954166e47d7cdcf9c540dea572b080e7b.1401191054.git.viresh.kumar@linaro.org> References: <2a9d8e2954166e47d7cdcf9c540dea572b080e7b.1401191054.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Enhance print messages for debugging purposes. Add a dev_err() whenever we fail to initialize OPP table due to some error in the table present in dts and add a dev_dbg() for success case. Signed-off-by: Viresh Kumar --- V4->V5: Fix rebase conflict as 2/8 has changed a bit drivers/base/power/opp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 28696af..ba20510 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -655,6 +655,8 @@ int of_init_opp_table(struct device *dev) } if (!prop->value) { + dev_err(dev, "%s: failed to init OPP: prop->value is NULL\n", + __func__); ret = -ENODATA; goto out; } @@ -681,6 +683,8 @@ int of_init_opp_table(struct device *dev) nr -= 2; } + dev_dbg(dev, "%s: successfully created OPP table\n", __func__); + out: of_node_put(dev->of_node); return 0;