[3/7] Enable gdb process record on aarch64-linux targets

Message ID 1401898871-2270-4-git-send-email-omair.javaid@linaro.org
State New
Headers show

Commit Message

Omair Javaid June 4, 2014, 4:21 p.m.
This patch adds linux-record.o to gdb_target_obs in configure.tgt for
aarch64*-linux* targets.

gdb:

2014-06-04  Omair Javaid  <omair.javaid@linaro.org>

	* configure.tgt: Add linux-record.o to gdb_target_obs.

---
 gdb/configure.tgt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Newton June 5, 2014, 8:59 a.m. | #1
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch adds linux-record.o to gdb_target_obs in configure.tgt for
> aarch64*-linux* targets.
>
> gdb:
>
> 2014-06-04  Omair Javaid  <omair.javaid@linaro.org>
>
>         * configure.tgt: Add linux-record.o to gdb_target_obs.
>
> ---
>  gdb/configure.tgt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks OK to me.

> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> index 01311b2..e9b906f 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -41,7 +41,7 @@ aarch64*-*-linux*)
>         # Target: AArch64 linux
>         gdb_target_obs="aarch64-tdep.o aarch64-linux-tdep.o \
>                         glibc-tdep.o linux-tdep.o solib-svr4.o \
> -                       symfile-mem.o"
> +                       symfile-mem.o linux-record.o"
>         build_gdbserver=yes
>         ;;
>
> --
> 1.9.1
>
Yao Qi Aug. 30, 2014, 3:30 a.m. | #2
Omair Javaid <omair.javaid@linaro.org> writes:

> This patch adds linux-record.o to gdb_target_obs in configure.tgt for
> aarch64*-linux* targets.
>
> gdb:
>
> 2014-06-04  Omair Javaid  <omair.javaid@linaro.org>
>
> 	* configure.tgt: Add linux-record.o to gdb_target_obs.

IIUC, linux-record.o provides the linux syscall support in process
record.  However, I don't see aarch64-linux syscall record is supported
in 4/7.  If so, do we still need this patch?
Omair Javaid Sept. 1, 2014, 7:49 p.m. | #3
On 30 August 2014 08:30, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> This patch adds linux-record.o to gdb_target_obs in configure.tgt for
>> aarch64*-linux* targets.
>>
>> gdb:
>>
>> 2014-06-04  Omair Javaid  <omair.javaid@linaro.org>
>>
>>       * configure.tgt: Add linux-record.o to gdb_target_obs.
>
> IIUC, linux-record.o provides the linux syscall support in process
> record.  However, I don't see aarch64-linux syscall record is supported
> in 4/7.  If so, do we still need this patch?
Here is aarch64 syscall record patch:
https://sourceware.org/ml/gdb-patches/2014-08/msg00636.html

>
> --
> Yao (齐尧)

Patch

diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index 01311b2..e9b906f 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -41,7 +41,7 @@  aarch64*-*-linux*)
 	# Target: AArch64 linux
 	gdb_target_obs="aarch64-tdep.o aarch64-linux-tdep.o \
 			glibc-tdep.o linux-tdep.o solib-svr4.o \
-			symfile-mem.o"
+			symfile-mem.o linux-record.o"
 	build_gdbserver=yes
 	;;