[1/6] netfilter: nfnetlink_acct: Fix memory leak

Message ID 1401980906-25290-2-git-send-email-pablo@netfilter.org
State New
Headers show

Commit Message

Pablo Neira Ayuso June 5, 2014, 3:08 p.m.
From: Mathieu Poirier <mathieu.poirier@linaro.org>

Allocation of memory need only to happen once, that is
after the proper checks on the NFACCT_FLAGS have been
done.  Otherwise the code can return without freeing
already allocated memory.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
 net/netfilter/nfnetlink_acct.c |    1 -
 1 file changed, 1 deletion(-)


diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c
index 70e86bb..54af985 100644
--- a/net/netfilter/nfnetlink_acct.c
+++ b/net/netfilter/nfnetlink_acct.c
@@ -83,7 +83,6 @@  nfnl_acct_new(struct sock *nfnl, struct sk_buff *skb,
 		return -EBUSY;
-	nfacct = kzalloc(sizeof(struct nf_acct), GFP_KERNEL);
 	if (tb[NFACCT_FLAGS]) {
 		flags = ntohl(nla_get_be32(tb[NFACCT_FLAGS]));
 		if (flags & ~NFACCT_F_QUOTA)