| Message ID | 20201101004357.1076876-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 0e77f8e1d0c22f768fb41f88ad14347b032c043f |
| Headers | show |
| Series | [1/2] extcon: fsa9480: Rewrite bindings in YAML and extend | expand |
Hi Linus, On 11/1/20 9:43 AM, Linus Walleij wrote: > This rewrites the FSA9480 DT bindings using YAML and > extends them with the compatible TI TSU6111. > > I chose to name the file fcs,fsa880 since this is the > first switch, later versions are improvements. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/extcon/extcon-fsa9480.txt | 21 -------- > .../bindings/extcon/fcs,fsa880.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > create mode 100644 Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > deleted file mode 100644 > index 624bd76f468e..000000000000 > --- a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -FAIRCHILD SEMICONDUCTOR FSA9480 MICROUSB SWITCH > - > -The FSA9480 is a USB port accessory detector and switch. The FSA9480 is fully > -controlled using I2C and enables USB data, stereo and mono audio, video, > -microphone, and UART data to use a common connector port. > - > -Required properties: > - - compatible : Must be one of > - "fcs,fsa9480" > - "fcs,fsa880" > - - reg : Specifies i2c slave address. Must be 0x25. > - - interrupts : Should contain one entry specifying interrupt signal of > - interrupt parent to which interrupt pin of the chip is connected. > - > - Example: > - musb@25 { > - compatible = "fcs,fsa9480"; > - reg = <0x25>; > - interrupt-parent = <&gph2>; > - interrupts = <7 0>; > - }; > diff --git a/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > new file mode 100644 > index 000000000000..ef6a246a1337 > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: https://protect2.fireeye.com/v1/url?k=da7a3fd4-85e106de-da7bb49b-0cc47a31384a-f57ab7f026383135&q=1&e=f8ca331d-3c11-4257-8322-d97ac13418ef&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fextcon%2Ffcs%2Cfsa880.yaml%23 > +$schema: https://protect2.fireeye.com/v1/url?k=0449819e-5bd2b894-04480ad1-0cc47a31384a-07ad90468a2ed371&q=1&e=f8ca331d-3c11-4257-8322-d97ac13418ef&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: Fairchild Semiconductor FSA880, FSA9480 and compatibles > + > +maintainers: > + - Linus Walleij <linus.walleij@linaro.org> > + > +description: > + The FSA880 and FSA9480 are USB port accessory detectors and switches. > + The switch is fully controlled using I2C and enables USB data, stereo > + and mono audio, video, microphone, and UART data to use a common > + connector port. Compatible switches exist from other manufacturers. > + > +properties: > + compatible: > + enum: > + - fcs,fsa880 > + - fcs,fsa9480 > + - ti,tsu6111 > + > + reg: > + maxItems: 1 > + description: The I2C address for an FSA880 compatible device is > + usually 0x25. > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + usb-switch@25 { > + compatible = "fcs,fsa880"; > + reg = <0x25>; > + interrupt-parent = <&gpio>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + }; > + }; > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> I'm waiting the reply from DT maintainer for a while. After that, I'll merge them. -- Best Regards, Chanwoo Choi Samsung Electronics
On Sun, 01 Nov 2020 01:43:56 +0100, Linus Walleij wrote: > This rewrites the FSA9480 DT bindings using YAML and > extends them with the compatible TI TSU6111. > > I chose to name the file fcs,fsa880 since this is the > first switch, later versions are improvements. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/extcon/extcon-fsa9480.txt | 21 -------- > .../bindings/extcon/fcs,fsa880.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt > create mode 100644 Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt deleted file mode 100644 index 624bd76f468e..000000000000 --- a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt +++ /dev/null @@ -1,21 +0,0 @@ -FAIRCHILD SEMICONDUCTOR FSA9480 MICROUSB SWITCH - -The FSA9480 is a USB port accessory detector and switch. The FSA9480 is fully -controlled using I2C and enables USB data, stereo and mono audio, video, -microphone, and UART data to use a common connector port. - -Required properties: - - compatible : Must be one of - "fcs,fsa9480" - "fcs,fsa880" - - reg : Specifies i2c slave address. Must be 0x25. - - interrupts : Should contain one entry specifying interrupt signal of - interrupt parent to which interrupt pin of the chip is connected. - - Example: - musb@25 { - compatible = "fcs,fsa9480"; - reg = <0x25>; - interrupt-parent = <&gph2>; - interrupts = <7 0>; - }; diff --git a/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml new file mode 100644 index 000000000000..ef6a246a1337 --- /dev/null +++ b/Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/extcon/fcs,fsa880.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Fairchild Semiconductor FSA880, FSA9480 and compatibles + +maintainers: + - Linus Walleij <linus.walleij@linaro.org> + +description: + The FSA880 and FSA9480 are USB port accessory detectors and switches. + The switch is fully controlled using I2C and enables USB data, stereo + and mono audio, video, microphone, and UART data to use a common + connector port. Compatible switches exist from other manufacturers. + +properties: + compatible: + enum: + - fcs,fsa880 + - fcs,fsa9480 + - ti,tsu6111 + + reg: + maxItems: 1 + description: The I2C address for an FSA880 compatible device is + usually 0x25. + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + usb-switch@25 { + compatible = "fcs,fsa880"; + reg = <0x25>; + interrupt-parent = <&gpio>; + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; + }; + };
This rewrites the FSA9480 DT bindings using YAML and extends them with the compatible TI TSU6111. I chose to name the file fcs,fsa880 since this is the first switch, later versions are improvements. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../bindings/extcon/extcon-fsa9480.txt | 21 -------- .../bindings/extcon/fcs,fsa880.yaml | 52 +++++++++++++++++++ 2 files changed, 52 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt create mode 100644 Documentation/devicetree/bindings/extcon/fcs,fsa880.yaml