| Message ID | 20201030023906.24259-5-kabel@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [leds,1/5] leds: turris-omnia: use constants instead of macros for color command | expand |
Hi! > LED core does not allow LED_COLOR_ID_MULTI for now and instead for RGB > LEDs prefers LED_COLOR_ID_RGB. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for > now") Thanks for patches. I have applied all but 4/, that is for Rob I guess. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c index c0b4e1e0e945..7b2f4d0ae3fe 100644 --- a/drivers/leds/leds-turris-omnia.c +++ b/drivers/leds/leds-turris-omnia.c @@ -90,9 +90,9 @@ static int omnia_led_register(struct i2c_client *client, struct omnia_led *led, } ret = of_property_read_u32(np, "color", &color); - if (ret || color != LED_COLOR_ID_MULTI) { + if (ret || color != LED_COLOR_ID_RGB) { dev_warn(dev, - "Node %pOF: must contain 'color' property with value LED_COLOR_ID_MULTI\n", + "Node %pOF: must contain 'color' property with value LED_COLOR_ID_RGB\n", np); return 0; }
LED core does not allow LED_COLOR_ID_MULTI for now and instead for RGB LEDs prefers LED_COLOR_ID_RGB. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") --- drivers/leds/leds-turris-omnia.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)