diff mbox series

ARM: OMAP2+: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare

Message ID 20201104064505.5737-1-vulab@iscas.ac.cn
State New
Headers show
Series ARM: OMAP2+: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare | expand

Commit Message

Xu Wang Nov. 4, 2020, 6:45 a.m. UTC
Because clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter, so the additional checks are unnecessary, just
remove them.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 arch/arm/mach-omap2/display.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Tony Lindgren Nov. 19, 2020, 9:53 a.m. UTC | #1
* Xu Wang <vulab@iscas.ac.cn> [201104 08:45]:
> Because clk_prepare_enable() and clk_disable_unprepare() already checked

> NULL clock parameter, so the additional checks are unnecessary, just

> remove them.


Thanks applying into omap-for-v5.11/soc.

Tony
diff mbox series

Patch

diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index 2000fca6bd4e..6daaa645ae5d 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -385,8 +385,7 @@  int omap_dss_reset(struct omap_hwmod *oh)
 	}
 
 	for (i = oh->opt_clks_cnt, oc = oh->opt_clks; i > 0; i--, oc++)
-		if (oc->_clk)
-			clk_prepare_enable(oc->_clk);
+		clk_prepare_enable(oc->_clk);
 
 	dispc_disable_outputs();
 
@@ -412,8 +411,7 @@  int omap_dss_reset(struct omap_hwmod *oh)
 		pr_debug("dss_core: softreset done\n");
 
 	for (i = oh->opt_clks_cnt, oc = oh->opt_clks; i > 0; i--, oc++)
-		if (oc->_clk)
-			clk_disable_unprepare(oc->_clk);
+		clk_disable_unprepare(oc->_clk);
 
 	r = (c == MAX_MODULE_SOFTRESET_WAIT) ? -ETIMEDOUT : 0;