| Message ID | cover.1402317549.git.riku.voipio@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 9 June 2014 13:46, <riku.voipio@linaro.org> wrote: > From: Riku Voipio <riku.voipio@linaro.org> > > Mostly fixes, but a bigger rework in signal.c to allow compiling with gcc-4.9 > > The following changes since commit 959e41473f2179850578482052fb73b913bc4e42: > > slirp/arp: do not special-case bogus IP addresses (2014-06-09 01:49:28 +0200) > > are available in the git repository at: > > git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream > > for you to fetch changes up to b4032ebd7dbfdc38430878c557c9c83c9f4ec2d0: > > User mode support for Linux ELF files with no section header (2014-06-09 15:19:59 +0300) Hi; I'm afraid this fails to build for me when building m68k-linux-user: /root/qemu/linux-user/signal.c: In function 'target_rt_restore_ucontext': /root/qemu/linux-user/signal.c:5079:5: error: 'err' may be used uninitialized in this function [-Werror=uninitialized] because the function never sets 'err' but then returns it. (32-bit, ARM, gcc 4.7.2. I don't know why the other compilers don't spot this; perhaps they inline the function and then figure out that the unused return value isn't actually ever used.) thanks -- PMM
On 9 June 2014 16:37, Peter Maydell <peter.maydell@linaro.org> wrote: > On 9 June 2014 13:46, <riku.voipio@linaro.org> wrote: >> From: Riku Voipio <riku.voipio@linaro.org> >> >> Mostly fixes, but a bigger rework in signal.c to allow compiling with gcc-4.9 >> >> The following changes since commit 959e41473f2179850578482052fb73b913bc4e42: >> >> slirp/arp: do not special-case bogus IP addresses (2014-06-09 01:49:28 +0200) >> >> are available in the git repository at: >> >> git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream >> >> for you to fetch changes up to b4032ebd7dbfdc38430878c557c9c83c9f4ec2d0: >> >> User mode support for Linux ELF files with no section header (2014-06-09 15:19:59 +0300) > > Hi; I'm afraid this fails to build for me when building > m68k-linux-user: > > /root/qemu/linux-user/signal.c: In function 'target_rt_restore_ucontext': > /root/qemu/linux-user/signal.c:5079:5: error: 'err' may be used > uninitialized in this function [-Werror=uninitialized] > > because the function never sets 'err' but then > returns it. > (32-bit, ARM, gcc 4.7.2. I don't know why the other > compilers don't spot this; perhaps they inline the > function and then figure out that the unused return > value isn't actually ever used.) Ok, I'll fix this and send another round. I'll also see some older toolchain for testing. Riku
From: Riku Voipio <riku.voipio@linaro.org> Mostly fixes, but a bigger rework in signal.c to allow compiling with gcc-4.9 The following changes since commit 959e41473f2179850578482052fb73b913bc4e42: slirp/arp: do not special-case bogus IP addresses (2014-06-09 01:49:28 +0200) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream for you to fetch changes up to b4032ebd7dbfdc38430878c557c9c83c9f4ec2d0: User mode support for Linux ELF files with no section header (2014-06-09 15:19:59 +0300) Alexander Graf (1): linux-user: Tell guest about big host page sizes Craig Heffner (1): User mode support for Linux ELF files with no section header Ed Swierk (1): linux-user: Return correct errno for unsupported netlink socket Peter Maydell (2): linux-user/uname: Return correct uname string for x86_64 linux-user: Don't overrun guest buffer in sched_getaffinity Riku Voipio (13): signal/all: remove __get/__put_user return value reading signal/x86/setup_frame: __put_user cleanup signal/all: remove return value from copy_siginfo_to_user signal/all: remove return value from setup_sigcontext signal/all: remove return value from restore_sigcontext signal/sparc/restore_fpu_state: remove signal/all/do_sigaltstack remove __get_user value check signal/all/do_sigreturn - remove __get_user checks signal/all/setup_frame remove __put_user checks signal/ppc/{save,restore}_user_regs remove __put/get error checks signal/sparc64_set_context: remove __get_user checks signal/ppc/do_setcontext remove __get_user return check linux-user: fix gcc-4.9 compiler error on __{get,put]}_user linux-user/elfload.c | 3 +- linux-user/qemu.h | 12 +- linux-user/signal.c | 1224 +++++++++++++++++++++----------------------------- linux-user/syscall.c | 18 +- linux-user/uname.c | 4 +- 5 files changed, 526 insertions(+), 735 deletions(-)