| Message ID | 20201103151452.416784-2-pbonzini@redhat.com |
|---|---|
| State | Accepted |
| Commit | 794b95608f8d92189baba697a7d6072e94ed2e0e |
| Headers | show |
| Series | deprecate short-form boolean options | expand |
On 03/11/2020 16.14, Paolo Bonzini wrote: > This QemuOpts idiom will be deprecated, so get rid of it in the tests. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > tests/qtest/ivshmem-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c > index d5c8b9f128..dfa69424ed 100644 > --- a/tests/qtest/ivshmem-test.c > +++ b/tests/qtest/ivshmem-test.c > @@ -135,7 +135,7 @@ static void setup_vm_cmd(IVState *s, const char *cmd, bool msix) > static void setup_vm(IVState *s) > { > char *cmd = g_strdup_printf("-object memory-backend-file" > - ",id=mb1,size=1M,share,mem-path=/dev/shm%s" > + ",id=mb1,size=1M,share=on,mem-path=/dev/shm%s" > " -device ivshmem-plain,memdev=mb1", tmpshm); > > setup_vm_cmd(s, cmd, false); > Reviewed-by: Thomas Huth <thuth@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes: > This QemuOpts idiom will be deprecated, so get rid of it in the tests. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > tests/qtest/ivshmem-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c > index d5c8b9f128..dfa69424ed 100644 > --- a/tests/qtest/ivshmem-test.c > +++ b/tests/qtest/ivshmem-test.c > @@ -135,7 +135,7 @@ static void setup_vm_cmd(IVState *s, const char *cmd, bool msix) > static void setup_vm(IVState *s) > { > char *cmd = g_strdup_printf("-object memory-backend-file" > - ",id=mb1,size=1M,share,mem-path=/dev/shm%s" > + ",id=mb1,size=1M,share=on,mem-path=/dev/shm%s" > " -device ivshmem-plain,memdev=mb1", tmpshm); > > setup_vm_cmd(s, cmd, false); Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index d5c8b9f128..dfa69424ed 100644 --- a/tests/qtest/ivshmem-test.c +++ b/tests/qtest/ivshmem-test.c @@ -135,7 +135,7 @@ static void setup_vm_cmd(IVState *s, const char *cmd, bool msix) static void setup_vm(IVState *s) { char *cmd = g_strdup_printf("-object memory-backend-file" - ",id=mb1,size=1M,share,mem-path=/dev/shm%s" + ",id=mb1,size=1M,share=on,mem-path=/dev/shm%s" " -device ivshmem-plain,memdev=mb1", tmpshm); setup_vm_cmd(s, cmd, false);
This QemuOpts idiom will be deprecated, so get rid of it in the tests. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- tests/qtest/ivshmem-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)