diff mbox series

[PATCH-for-5.2?,2/5] tests/acceptance: Restore MIPS Malta multicore tests

Message ID 20201102144245.2134077-3-philmd@redhat.com
State New
Headers show
Series [PATCH-for-5.2?,1/5] tests/acceptance: Restrict virtio_check_params tests to X86 target | expand

Commit Message

Philippe Mathieu-Daudé Nov. 2, 2020, 2:42 p.m. UTC
Since 42a052333a6 ("hw/misc/mips_cpc: Start vCPU when powered on")
the multicore support of the MIPS Malta board has been fixed.

This reverts commit 61bbce96fe4c8e3a2b7df5a67ba7dc6ba418e54b.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/acceptance/machine_mips_malta.py | 2 --
 1 file changed, 2 deletions(-)

Comments

Philippe Mathieu-Daudé Nov. 3, 2020, 6:27 a.m. UTC | #1
On 11/2/20 3:42 PM, Philippe Mathieu-Daudé wrote:
> Since 42a052333a6 ("hw/misc/mips_cpc: Start vCPU when powered on")

> the multicore support of the MIPS Malta board has been fixed.

> 

> This reverts commit 61bbce96fe4c8e3a2b7df5a67ba7dc6ba418e54b.

> 

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---

>  tests/acceptance/machine_mips_malta.py | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/tests/acceptance/machine_mips_malta.py b/tests/acceptance/machine_mips_malta.py

> index 7c9a4ee4d2d..eea046141d6 100644

> --- a/tests/acceptance/machine_mips_malta.py

> +++ b/tests/acceptance/machine_mips_malta.py

> @@ -100,7 +100,6 @@ def test_mips_malta_i6400_framebuffer_logo_1core(self):

>          """

>          self.do_test_i6400_framebuffer_logo(1)

>  

> -    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')

>      def test_mips_malta_i6400_framebuffer_logo_7cores(self):

>          """

>          :avocado: tags=arch:mips64el

> @@ -110,7 +109,6 @@ def test_mips_malta_i6400_framebuffer_logo_7cores(self):

>          """

>          self.do_test_i6400_framebuffer_logo(7)

>  

> -    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')

>      def test_mips_malta_i6400_framebuffer_logo_8cores(self):


And this still doesn't work... :(
https://gitlab.com/philmd/qemu/-/jobs/826406235#L218
diff mbox series

Patch

diff --git a/tests/acceptance/machine_mips_malta.py b/tests/acceptance/machine_mips_malta.py
index 7c9a4ee4d2d..eea046141d6 100644
--- a/tests/acceptance/machine_mips_malta.py
+++ b/tests/acceptance/machine_mips_malta.py
@@ -100,7 +100,6 @@  def test_mips_malta_i6400_framebuffer_logo_1core(self):
         """
         self.do_test_i6400_framebuffer_logo(1)
 
-    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
     def test_mips_malta_i6400_framebuffer_logo_7cores(self):
         """
         :avocado: tags=arch:mips64el
@@ -110,7 +109,6 @@  def test_mips_malta_i6400_framebuffer_logo_7cores(self):
         """
         self.do_test_i6400_framebuffer_logo(7)
 
-    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
     def test_mips_malta_i6400_framebuffer_logo_8cores(self):
         """
         :avocado: tags=arch:mips64el