diff mbox series

[v2,09/10] dt-bindings: arm: hisilicon: add missing properties into sysctrl.yaml

Message ID 20201012061225.1597-10-thunder.leizhen@huawei.com
State New
Headers show
Series clean up all Hisilicon-related errors detected by DT schema on arm32 | expand

Commit Message

Leizhen (ThunderTown) Oct. 12, 2020, 6:12 a.m. UTC 
Add properties: #reset-cells, #address-cells, #size-cells and ranges. Due
to the Hisilicon system controller node may contains child nodes, change
the value of "additionalProperties" from "false" to "type: object". The
examples have also been updated.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

---
 .../bindings/arm/hisilicon/controller/sysctrl.yaml | 28 +++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

-- 
1.8.3

Comments

Rob Herring (Arm) Oct. 12, 2020, 6:48 p.m. UTC | #1 
On Mon, 12 Oct 2020 14:12:24 +0800, Zhen Lei wrote:
> Add properties: #reset-cells, #address-cells, #size-cells and ranges. Due

> to the Hisilicon system controller node may contains child nodes, change

> the value of "additionalProperties" from "false" to "type: object". The

> examples have also been updated.

> 

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

> ---

>  .../bindings/arm/hisilicon/controller/sysctrl.yaml | 28 +++++++++++++++++++---

>  1 file changed, 25 insertions(+), 3 deletions(-)

> 


Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
index 449140f89ddbc3b..5a53d433b6f0891 100644
--- a/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
+++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
@@ -71,21 +71,43 @@  properties:
   '#clock-cells':
     const: 1
 
+  '#reset-cells':
+    const: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
 required:
   - compatible
   - reg
 
-additionalProperties: false
+additionalProperties:
+  type: object
 
 examples:
   - |
     /* Hisilicon system controller */
-    system-controller@fc802000 {
+    system-controller@802000 {
         compatible = "hisilicon,sysctrl", "syscon";
-        reg = <0xfc802000 0x1000>;
+        #address-cells = <1>;
+        #size-cells = <1>;
+        ranges = <0 0x802000 0x1000>;
+        reg = <0x802000 0x1000>;
+
         smp-offset = <0x31c>;
         resume-offset = <0x308>;
         reboot-offset = <0x4>;
+
+        clock: clock@0 {
+            compatible = "hisilicon,hi3620-clock";
+            reg = <0 0x10000>;
+            #clock-cells = <1>;
+        };
     };
 
     /* HiP01 system controller */