| Message ID | 20201104235134.17793-1-rikard.falkeborn@gmail.com |
|---|---|
| State | Accepted |
| Commit | 0d66442dfdbd45019c60bb6aeaf2d5eb45534606 |
| Headers | show |
| Series | tty: serial: msm_serial: Constify msm_uart_pops | expand |
On Wed, Nov 4, 2020 at 4:54 PM Rikard Falkeborn <rikard.falkeborn@gmail.com> wrote: > > The only usage of msm_uart_pops is to assign its address to the ops > field in the uart_port struct, which is a pointer to const. Make it > const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Thu, 5 Nov 2020 00:51:34 +0100 you wrote: > The only usage of msm_uart_pops is to assign its address to the ops > field in the uart_port struct, which is a pointer to const. Make it > const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/tty/serial/msm_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - tty: serial: msm_serial: Constify msm_uart_pops https://git.kernel.org/qcom/c/0d66442dfdbd You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 87f005e5d2af..18e16159aabb 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -1525,7 +1525,7 @@ static void msm_poll_put_char(struct uart_port *port, unsigned char c) } #endif -static struct uart_ops msm_uart_pops = { +static const struct uart_ops msm_uart_pops = { .tx_empty = msm_tx_empty, .set_mctrl = msm_set_mctrl, .get_mctrl = msm_get_mctrl,
The only usage of msm_uart_pops is to assign its address to the ops field in the uart_port struct, which is a pointer to const. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/tty/serial/msm_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)