[05/11] sh_mmcif: unmap with the proper sglen

Message ID AANLkTikEQaY67it=RJkZQR6ufCE5M-hG8O45p0MJNZ81@mail.gmail.com
State Accepted, archived
Headers show

Commit Message

Linus Walleij March 4, 2011, 10:26 a.m.
---------- Forwarded message ----------
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, Feb 10, 2011 at 4:09 PM
Subject: [PATCH 05/11] sh_mmcif: unmap with the proper sglen
To: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Cc: Dan Williams <dan.j.williams@intel.com>, Paul Mundt
<lethal@linux-sh.org>, Linus Walleij <linus.walleij@linaro.org>


According to the DMA-API you shall unmap the sglists with the same
sglist length as passed into the mapping function, not the
returned value from the mapping function.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/host/sh_mmcif.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--
1.7.4

Patch

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 8e4aba9..61ad19e 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -195,11 +195,11 @@  static void mmcif_dma_complete(void *arg)

       if (host->data->flags & MMC_DATA_READ)
               dma_unmap_sg(host->chan_rx->device->dev,
-                            host->data->sg, host->dma_sglen,
+                            host->data->sg, host->data->sg_len,
                            DMA_FROM_DEVICE);
       else
               dma_unmap_sg(host->chan_tx->device->dev,
-                            host->data->sg, host->dma_sglen,
+                            host->data->sg, host->data->sg_len,
                            DMA_TO_DEVICE);

       complete(&host->dma_complete);