| Message ID | 1603708855-2663-1-git-send-email-shengjiu.wang@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] ASoC: dt-bindings: fsl_aud2htx: Add binding doc for aud2htx module | expand |
On Mon, Oct 26, 2020 at 06:40:54PM +0800, Shengjiu Wang wrote: > AUD2HTX (Audio Subsystem TO HDMI TX Subsystem) is a new > IP module found on i.MX8MP. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- > .../bindings/sound/fsl,aud2htx.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml b/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml > new file mode 100644 > index 000000000000..18548d0889a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/fsl,aud2htx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP Audio Subsystem to HDMI RTX Subsystem Controller > + > +maintainers: > + - Shengjiu Wang <shengjiu.wang@nxp.com> > + > +properties: > + $nodename: > + pattern: "^aud2htx@.*" aud2htx is not a generic class of a device so it should not be enforced. > + > + compatible: > + const: fsl,imx8mp-aud2htx > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Peripheral clock > + > + clock-names: > + items: > + - const: bus > + > + dmas: > + items: > + - description: DMA controller phandle and request line for TX > + > + dma-names: > + items: > + - const: tx > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - dmas > + - dma-names > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/imx8mp-clock.h> > + > + aud2htx: aud2htx@30cb0000 { > + compatible = "fsl,imx8mp-aud2htx"; Wrong indentation. Most of examples are indented with 4 spaces. Best regards, Krzysztof
On Tue, Oct 27, 2020 at 7:09 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Oct 26, 2020 at 06:40:54PM +0800, Shengjiu Wang wrote: > > AUD2HTX (Audio Subsystem TO HDMI TX Subsystem) is a new > > IP module found on i.MX8MP. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > --- > > .../bindings/sound/fsl,aud2htx.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml b/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml > > new file mode 100644 > > index 000000000000..18548d0889a8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/fsl,aud2htx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP Audio Subsystem to HDMI RTX Subsystem Controller > > + > > +maintainers: > > + - Shengjiu Wang <shengjiu.wang@nxp.com> > > + > > +properties: > > + $nodename: > > + pattern: "^aud2htx@.*" > > aud2htx is not a generic class of a device so it should not be enforced. > > > + > > + compatible: > > + const: fsl,imx8mp-aud2htx > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Peripheral clock > > + > > + clock-names: > > + items: > > + - const: bus > > + > > + dmas: > > + items: > > + - description: DMA controller phandle and request line for TX > > + > > + dma-names: > > + items: > > + - const: tx > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - dmas > > + - dma-names > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/clock/imx8mp-clock.h> > > + > > + aud2htx: aud2htx@30cb0000 { > > + compatible = "fsl,imx8mp-aud2htx"; > > Wrong indentation. Most of examples are indented with 4 spaces. > ok, I will update it. best regards wang shengjiu
diff --git a/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml b/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml new file mode 100644 index 000000000000..18548d0889a8 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml @@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/fsl,aud2htx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Audio Subsystem to HDMI RTX Subsystem Controller + +maintainers: + - Shengjiu Wang <shengjiu.wang@nxp.com> + +properties: + $nodename: + pattern: "^aud2htx@.*" + + compatible: + const: fsl,imx8mp-aud2htx + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: Peripheral clock + + clock-names: + items: + - const: bus + + dmas: + items: + - description: DMA controller phandle and request line for TX + + dma-names: + items: + - const: tx + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - dmas + - dma-names + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/imx8mp-clock.h> + + aud2htx: aud2htx@30cb0000 { + compatible = "fsl,imx8mp-aud2htx"; + reg = <0x30cb0000 0x10000>; + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&audiomix_clk IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; + clock-names = "bus"; + dmas = <&sdma2 26 2 0>; + dma-names = "tx"; + power-domains = <&audiomix_pd>; + };
AUD2HTX (Audio Subsystem TO HDMI TX Subsystem) is a new IP module found on i.MX8MP. Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- .../bindings/sound/fsl,aud2htx.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,aud2htx.yaml -- 2.27.0